Fix broken GitHub Actions after switch to MAINTAINER_LIST

[justinretzolk]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23636

Output from acceptance testing: n/a, relates to GitHub Actions

Information

The linked Pull Request updated several GitHub Actions to use the new MAINTAINER_LIST secret to pull a list of users for an exclusion list. Unfortunately, this broke many of the workflows, so this PR aims to fix it.

There seems to be some inconsistencies, but the best I could tell, this is a result of using the secrets context in jobs.<job-id>.if definitions. Per the context availability docs this isn't supported (though it seemed to work on some Actions, so I'm still scratching my head a little).

Because of that, this PR introduces a top level env definition that evaluates the contains() block (the same way we were doing it in jobs.<job-id>.if previously) and then moves the conditional to jobs.<job-id>.steps.if, where env is supported.

[github-actions]

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.