Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GitHub Actions to use MAINTAINER_LIST secret #23636

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

justinretzolk
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23633

Output from acceptance testing: n/a, meta PR for GitHub Actions

Information

This PR comes after the linked PR is merged and the secret has been created by approving the resulting Terraform run. Once that has completed, this PR can be merged to switch the GitHub Actions over to using the MAINTAINER_LIST secret rather than a statically defined list.

@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XS Managed by automation to categorize the size of a PR. labels Mar 11, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@justinretzolk justinretzolk merged commit 392d1c1 into main Mar 11, 2022
@justinretzolk justinretzolk deleted the m-actions-use-secrets-for-maintainer-list branch March 11, 2022 19:16
@github-actions github-actions bot added this to the v4.5.0 milestone Mar 11, 2022
@github-actions
Copy link

This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants