build(deps): bump github.com/golangci/golangci-lint from 1.37.1 to 1.39.0 in /tools #18510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.37.1 to 1.39.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.37.1...v1.39.0) Signed-off-by: dependabot[bot] <support@github.com>
Previously:
```
aws/resource_aws_lb_target_group.go:427:4: ineffectual assignment to params (ineffassign)
params = &elbv2.ModifyTargetGroupInput{
^
```
Output from acceptance testing:
```
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (39.17s)
--- PASS: TestAccAWSLBTargetGroup_basic (45.45s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (35.68s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (99.19s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (99.20s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (95.43s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (65.16s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (48.32s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (49.86s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (44.87s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (56.27s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (51.33s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (134.41s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (68.68s)
--- PASS: TestAccAWSLBTargetGroup_preserveClientIPValid (83.27s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (49.80s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (92.44s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (51.33s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (34.64s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (64.98s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (83.33s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (62.77s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (130.76s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (84.61s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (58.79s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (65.08s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (168.27s)
--- PASS: TestAccAWSLBTargetGroup_tags (104.25s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (69.58s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (88.88s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (97.19s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (29.58s)
```
|
Previous CI failure due to new error report: Output from acceptance testing after removing that: |
bflad
deleted the
dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.39.0
branch
|
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/golangci/golangci-lint from 1.37.1 to 1.39.0.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Commits
9aea4aetypecheck: display compilation errors as report instead of error (#1861)ccb5bd0docs: add cache directory information. (#1871)bcdfb7fdocs: typo fixes in architecture.mdx (#1870)814bf0eSet version command output to Stdout (#1869)82778e2Bump importas to HEAD (#1864)e23f80ebuild(deps): bump github.com/mgechev/revive from 1.0.3 to 1.0.5 (#1866)ba6e969build(deps): bump github.com/go-critic/go-critic from 0.5.4 to 0.5.5 (#1867)fb394a9Bump makezero to HEAD (#1865)03992d0Bump wrapcheck to v1.0.0 (#1863)809be02fix: linters load mode (#1862)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually