Skip to content

Commit

Permalink
build(deps): bump github.com/golangci/golangci-lint from 1.37.1 to 1.…
Browse files Browse the repository at this point in the history
…39.0 in /tools (#18510)

* build(deps): bump github.com/golangci/golangci-lint in /tools

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.37.1 to 1.39.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.37.1...v1.39.0)

Signed-off-by: dependabot[bot] <support@github.com>

* resource/aws_lb_target_group: Fix new ineffassign report

Previously:

```
aws/resource_aws_lb_target_group.go:427:4: ineffectual assignment to params (ineffassign)
			params = &elbv2.ModifyTargetGroupInput{
			^
```

Output from acceptance testing:

```
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (39.17s)
--- PASS: TestAccAWSLBTargetGroup_basic (45.45s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (35.68s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (99.19s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (99.20s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (95.43s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (65.16s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (48.32s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (49.86s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (44.87s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (56.27s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (51.33s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (134.41s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (68.68s)
--- PASS: TestAccAWSLBTargetGroup_preserveClientIPValid (83.27s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (49.80s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (92.44s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (51.33s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (34.64s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (64.98s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (83.33s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (62.77s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (130.76s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (84.61s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (58.79s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (65.08s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (168.27s)
--- PASS: TestAccAWSLBTargetGroup_tags (104.25s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (69.58s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (88.88s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (97.19s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (29.58s)
```

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brian Flad <bflad417@gmail.com>
  • Loading branch information
dependabot[bot] and bflad authored Mar 31, 2021
1 parent c49c6c2 commit 47b0d8b
Show file tree
Hide file tree
Showing 3 changed files with 264 additions and 84 deletions.
3 changes: 0 additions & 3 deletions aws/resource_aws_lb_target_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,6 @@ func resourceAwsLbTargetGroupUpdate(d *schema.ResourceData, meta interface{}) er
var params *elbv2.ModifyTargetGroupInput
healthChecks := d.Get("health_check").([]interface{})
if len(healthChecks) == 1 {
params = &elbv2.ModifyTargetGroupInput{
TargetGroupArn: aws.String(d.Id()),
}
healthCheck := healthChecks[0].(map[string]interface{})

params = &elbv2.ModifyTargetGroupInput{
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.15
require (
github.com/bflad/tfproviderdocs v0.9.1
github.com/client9/misspell v0.3.4
github.com/golangci/golangci-lint v1.37.1
github.com/golangci/golangci-lint v1.39.0
github.com/hashicorp/go-changelog v0.0.0-20201005170154-56335215ce3a
github.com/hashicorp/go-getter v1.5.2 // indirect
github.com/katbyte/terrafmt v0.3.0
Expand Down
Loading

0 comments on commit 47b0d8b

Please sign in to comment.