Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt to hide the dropdown if it's showing #1277

Merged
merged 1 commit into from
Jun 17, 2013

Conversation

rbright
Copy link

@rbright rbright commented Jun 15, 2013

There are multiple events that trigger the results_hide function.

  1. Expand a dropdown and close it again. This triggers results_hide through the results_toggle function. Note that the dropdown is still highlighted.
  2. Focus on another element. This triggers results_hide through the close_field function.

Suppose we have two Chosen dropdowns.

Expanding the first dropdown sets @results_showing to true. Closing it sets the flag to false. However, expanding the second dropdown will first toggle the flag to true but then toggle it back to false when results_hide is called as a result of close_field.

An example of this behavior can be seen at http://www.getharvest.com/platform.

pfiller added a commit that referenced this pull request Jun 17, 2013
Only attempt to hide the dropdown if it's showing
@pfiller pfiller merged commit 5d60f3b into harvesthq:master Jun 17, 2013
pfiller added a commit that referenced this pull request Jun 17, 2013
pfiller added a commit that referenced this pull request Jun 17, 2013
Show disabled options #1262
Only attempt to hide the dropdown if it's showing #1277
Add more margin for single selects with allow_single_deselect #1257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants