Only attempt to hide the dropdown if it's showing #1277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple events that trigger the
results_hide
function.results_hide
through theresults_toggle
function. Note that the dropdown is still highlighted.results_hide
through theclose_field
function.Suppose we have two Chosen dropdowns.
Expanding the first dropdown sets
@results_showing
totrue
. Closing it sets the flag tofalse
. However, expanding the second dropdown will first toggle the flag totrue
but then toggle it back tofalse
whenresults_hide
is called as a result ofclose_field
.An example of this behavior can be seen at http://www.getharvest.com/platform.