Add more margin for single selects with allow_single_deselect #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1! |
|
@mlharvest ooh - an enthusiastic +1! |
pfiller
added a commit
that referenced
this pull request
Jun 4, 2013
Add more margin for single selects with allow_single_deselect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mlharvest @kenearley @stof
This is a relatively simple change that adds more margin to the
spanpreceding Chosen's delete control whenallow_single_deselect: true. This fixes an issue when option text is longer than the width of the select (as described in #1250). I had to add a class toselected_itembecause there's no adjacent sibling selector in CSS that works backwards.Fixes #1250