This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
refactor: structure of the setting spec #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
kind/improvement
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
f2c-ci-robot
bot
added
release-note-none
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Sep 22, 2022
#### What type of PR is this? /kind improvement /milestone 2.0 /kind api-change #### What this PR does / why we need it: 重构 Setting 模型的结构，适配 halo-dev/halo#2440 todo list: - [x] 更新 `@halo-dev/api-client` #### Which issue(s) this PR fixes: Fixes halo-dev/halo#2414 #### Special notes for your reviewer: 测试方式： 1. 本地 admin 仓库切换到当前 PR 的分支，halo 仓库切换到 halo-dev/halo#2440 PR 的分支。 2. 测试后台各个表单功能是否正常。 3. 主题设置表单可使用 halo-sigs/theme-anatole#2 PR 的分支进行测试。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改 settings.yaml 的 spec 定义。适配 halo-dev/halo#2440
/kind improvement
/kind api-change