Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: structure of the setting extension #616

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 21, 2022

What type of PR is this?

/kind improvement
/milestone 2.0
/kind api-change

What this PR does / why we need it:

重构 Setting 模型的结构,适配 halo-dev/halo#2440

todo list:

  • 更新 @halo-dev/api-client

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2414

Special notes for your reviewer:

测试方式:

  1. 本地 admin 仓库切换到当前 PR 的分支,halo 仓库切换到 feat: create a configmap based on the setting definition when installing a theme halo#2440 PR 的分支。
  2. 测试后台各个表单功能是否正常。
  3. 主题设置表单可使用 refactor: structure of the setting spec halo-sigs/theme-anatole#2 PR 的分支进行测试。

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG September 21, 2022 07:06
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 21, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Sep 21, 2022
@vercel
Copy link

vercel bot commented Sep 21, 2022

@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel.

A member of the Team first needs to authorize it.

@f2c-ci-robot f2c-ci-robot bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 21, 2022
@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-admin-next ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 8:23AM (UTC)
halo-admin-ui ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 8:23AM (UTC)

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit f2f657b into halo-dev:next Sep 22, 2022
@ruibaby ruibaby deleted the refactor/setting-spec branch September 22, 2022 08:32
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind improvement
/milestone 2.0
/kind api-change

#### What this PR does / why we need it:

重构 Setting 模型的结构,适配 halo-dev#2440

todo list:

- [x] 更新 `@halo-dev/api-client`

#### Which issue(s) this PR fixes:

Fixes halo-dev#2414

#### Special notes for your reviewer:

测试方式:

1. 本地 admin 仓库切换到当前 PR 的分支,halo 仓库切换到 halo-dev#2440 PR 的分支。
2. 测试后台各个表单功能是否正常。
3. 主题设置表单可使用 halo-sigs/theme-anatole#2 PR 的分支进行测试。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants