This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 482
refactor: structure of the setting extension #616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Ryan Wang <i@ryanc.cc>
JohnNiang
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement /milestone 2.0 /kind api-change #### What this PR does / why we need it: 重构 Setting 模型的结构,适配 halo-dev#2440 todo list: - [x] 更新 `@halo-dev/api-client` #### Which issue(s) this PR fixes: Fixes halo-dev#2414 #### Special notes for your reviewer: 测试方式: 1. 本地 admin 仓库切换到当前 PR 的分支,halo 仓库切换到 halo-dev#2440 PR 的分支。 2. 测试后台各个表单功能是否正常。 3. 主题设置表单可使用 halo-sigs/theme-anatole#2 PR 的分支进行测试。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
kind/improvement
Categorizes issue or PR as related to a improvement.
lgtm
Indicates that a PR is ready to be merged.
release-note-none
Denotes a PR that doesn't merit a release note.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/milestone 2.0
/kind api-change
What this PR does / why we need it:
重构 Setting 模型的结构,适配 halo-dev/halo#2440
todo list:
@halo-dev/api-client
Which issue(s) this PR fixes:
Fixes halo-dev/halo#2414
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?