FV3_HRRR_gf (RRFS physics) support mostly works #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelTrahanNOAA
requested review from
BinLiu-NOAA,
ZhanZhang-NOAA,
KathrynNewman and
panll
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NOTE: This is try to of PR #292 which was merged prematurely.
Do not merge this until the dependencies are merged. I don't want to open a third PR.
Adds support for FV3_HRRR_gf suite. The nest motion code will shift nearly all variables. There are corrections to parm files (ltaerosol was off). All tested cycles work.
This PR is mostly to let @mrinalbiswas start testing the configuration.
Issues addressed (optional)
N/A
Dependencies (optional)
Contributors (optional)
Development thus far has mostly been me, but I do have some bug fixes from @mrinalbiswas.
Tests conducted
Only tested on Hercules, since that's where our resources are.
Ran 2020 13L cycles 2020082506 through 2020082618 with mom6 and ww3 coupling. A
Also ran 2023 10L, cycles 2023082618-2023082700 with no error. Succeeded uncoupled, and also coupled with mom6+ww3.
Application-level regression test status
None yet; @mrinalbiswas is working on this.