FV3_HRRR_gf (RRFS physics) support mostly works #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelTrahanNOAA
requested review from
BinLiu-NOAA,
ZhanZhang-NOAA,
KathrynNewman and
panll
as code owners
BijuThomas-NOAA
added a commit
that referenced
this pull request
Oct 18, 2024
|
@mrinalbiswas - We can't merge this yet. We must merge the prerequisites first, and one of them has conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds support for FV3_HRRR_gf suite. It nearly always works now.
The one time it doesn't work is the 2020082518 cycle of 13L. If you set the forecast length to 24 hours, it'll run to 24 hours, and abort during model finalization with a NaN. Instead, if you set the forecast length above 24 hours, or below 23 hours, and it'll run just fine.
This PR is mostly to let @mrinalbiswas start testing the configuration.
Also, there are some bug fixes to the ww3 initialization. Some regular expressions used a syntax that isn't supported in Python 3.11 and newer.
Issues addressed (optional)
N/A
Dependencies (optional)
If submodule PRs are required, please link them below. For example:
Contributors (optional)
Development thus far has mostly been me, but I do have some bug fixes from @mrinalbiswas.
Tests conducted
Only tested on Hercules, since that's where our resources are.
Ran 2020 13L cycles 2020082506 through 2020082618 with mom6 and ww3 coupling. All cycles worked except the one mentioned earlier. The
rocoto/HRRRGF-mom6-ww3.shwill reproduce this bug.Also ran 2023 10L, cycles 2023082618-2023082700 with no error. Succeeded uncoupled, and also coupled with mom6+ww3.
Application-level regression test status
None yet; @mrinalbiswas is working on this.