Callouts in DCR - PR 3/5 - Add new form #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -87.5 kB (-4%) Total Size: 2.31 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
tkgnm
commented
Dec 22, 2022
| @@ -0,0 +1,258 @@ | |||
| import type { CalloutBlockElementV2 } from '../../src/types/content'; | |||
There was a problem hiding this comment.
This is the mock campaign for the story. It uses every type of callout field that we should expect.
tkgnm
commented
Dec 22, 2022
| @@ -84,7 +84,7 @@ | |||
| "@guardian/shimport": "^1.0.2", | |||
| "@guardian/source-foundations": "^7.0.1", | |||
| "@guardian/source-react-components": "^9.0.0", | |||
| "@guardian/source-react-components-development-kitchen": "6.0.2", | |||
| "@guardian/source-react-components-development-kitchen": "8.1.0", | |||
There was a problem hiding this comment.
This is so we can use the new shareCallout svg from source
There was a problem hiding this comment.
If you bump this to 8.2.0 you'll get the updated styling for the FileInput field as well
There was a problem hiding this comment.
Brilliant! Thanks - will do this next PR, as I'll have to for the tabs anyway
tkgnm
commented
Dec 22, 2022
tkgnm
commented
Dec 22, 2022
tkgnm
commented
Dec 22, 2022
sophie-macmillan
requested changes
Dec 23, 2022
tkgnm
commented
Dec 23, 2022
dotcom-rendering/src/web/components/CalloutEmbed/Form.stories.tsx
Outdated
Show resolved
Hide resolved
This was referenced Dec 23, 2022
tkgnm
changed the title
This was referenced Dec 23, 2022
This reverts commit b9adaf1.
…on-share-t&c-expired' into add-callout-form-dcr
tkgnm
commented
Jan 3, 2023
dotcom-rendering/src/web/components/Callout/CalloutComponents.tsx
Outdated
Show resolved
Hide resolved
tkgnm
commented
Jan 3, 2023
tkgnm
commented
Jan 3, 2023
abeddow91
approved these changes
Jan 4, 2023
sophie-macmillan
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callouts in DCR
This PR is part of a larger body of work to create a new Callout component in DCR. We are separating this PR into chunks so that it is easier to communicate the intent of each PR and to make it easier for DCR to review. After each PR is merged, we can merge it into the next branch which will incrementally reduce the size of each subsequent PR.
Important note for DCR reviewers: Please review these PR's in order below!
PR 1 #6741
PR 2 #6819
PR 3 this PR
PR 4 #6872
PR 5 #6836
Why?
This PR adds the form that our readers use to submit their experiences. It will live inside a
CalloutBlockElement- that component is not added in this PR, it will be added in PR 4 #6872What does this change?
This PR adds the form, some stories and some tests.
Testing
These components are not being used anywhere in production yet. They will be in a subsequent PR. For now, I recommend testing via the new story file.
Screenshots