Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callouts in DCR - PR 4/5 - Add new CalloutBlockElement #6806

Closed
wants to merge 148 commits into from
Closed

Callouts in DCR - PR 4/5 - Add new CalloutBlockElement #6806

wants to merge 148 commits into from

Conversation

tkgnm
Copy link
Contributor

@tkgnm tkgnm commented Dec 15, 2022 •
edited
Loading

Callouts in DCR

This PR is part of a larger body of work to create a new Callout component in DCR. We are separating this PR into chunks so that it is easier to communicate the intent of each PR and to make it easier for DCR to review. After each PR is merged, we can merge it into the next branch which will incrementally reduce the size of each subsequent PR.

Important note for DCR reviewers: Please review these PR's in order below!

PR 1 #6741
PR 2 #6819
PR 3 #6833
PR 4 #6806
PR 5 #6836

Why?

What does this change?

Screenshots

Before After
before after

tkgnm added 30 commits October 31, 2022 11:54
@tkgnm
skeleton callout
f944828
@tkgnm
rename to formfields
b847a20
@tkgnm
map working
d3b59cd
@tkgnm
more closely matching original callout
96b1b20
@tkgnm
working with old components
46521bd 
time to create some new ones!
@tkgnm
made separate components
5c1c766
@tkgnm
updated calloutCampaign fields
5b1811b
@tkgnm
added disclaimer field, submit button
55cbc59
@tkgnm
Formatting submit button, removing terms and conditions
00a8b13
@tkgnm
Updating where do you live description
975d48a
@tkgnm
updating email address description
def5f11
@tkgnm
submit button
f5b916e
@tkgnm
added description to textarea
8631b7e
@tkgnm
added select box
f8a1b62
@tkgnm
improvements to description of file upload and button
82df12c
@tkgnm
updating disclaimer formatting, removing from form
4d4d808
@tkgnm
created new callout block component
896b580
@tkgnm
prettier formatting
9a836ed
@tkgnm
fix linting errors
4b4dc3b
@tkgnm
block component title and description now in
94c7a3f
@tkgnm
formatting description
3f2f1c5
@tkgnm
formatting title
15c9312
@tkgnm
Adding share your experience field
3e13773
@tkgnm
formatting
f69e2ff
@tkgnm
added placeholder dot
2730edc
@tkgnm
setting text colour of link
8060271
@tkgnm
updating border of placeholder button
b5aa364
@tkgnm
create ShareCalloutComponent
56f08f7
@tkgnm
created expanding wrapper
6375c02
@tkgnm
added terms and conditions
a6b86c4
@github-actions
Copy link

github-actions bot commented Dec 22, 2022 •
edited
Loading

Size Change: -122 kB (-5%) ✅

Total Size: 2.32 MB

Filename Size Change
dotcom-rendering/dist/1124.modern.********************.js 0 B -8.35 kB (removed) 🏆
dotcom-rendering/dist/1398.legacy.********************.js 0 B -5.41 kB (removed) 🏆
dotcom-rendering/dist/1398.modern.********************.js 0 B -5.3 kB (removed) 🏆
dotcom-rendering/dist/2054.legacy.********************.js 0 B -25.6 kB (removed) 🏆
dotcom-rendering/dist/2054.modern.********************.js 0 B -24.4 kB (removed) 🏆
dotcom-rendering/dist/3559.legacy.********************.js 0 B -5.6 kB (removed) 🏆
dotcom-rendering/dist/446.modern.********************.js 0 B -3.32 kB (removed) 🏆
dotcom-rendering/dist/642.js 0 B -9 kB (removed) 🏆
dotcom-rendering/dist/7198.modern.********************.js 0 B -5.47 kB (removed) 🏆
dotcom-rendering/dist/7716.legacy.********************.js 0 B -9.16 kB (removed) 🏆
dotcom-rendering/dist/7829.legacy.********************.js 0 B -4.07 kB (removed) 🏆
dotcom-rendering/dist/9030.legacy.********************.js 0 B -4.01 kB (removed) 🏆
dotcom-rendering/dist/9439.legacy.********************.js 0 B -4.94 kB (removed) 🏆
dotcom-rendering/dist/9933.legacy.********************.js 0 B -9.14 kB (removed) 🏆
dotcom-rendering/dist/9933.modern.********************.js 0 B -8.61 kB (removed) 🏆
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 5.5 kB +843 B (+18%) ⚠️
dotcom-rendering/dist/DiscussionMeta-importable.legacy.********************.js 3.33 kB +1.08 kB (+48%) 🚨
dotcom-rendering/dist/frontend.server.js 433 kB +6.42 kB (+2%)
dotcom-rendering/dist/KeyEventsCarousel-importable.legacy.********************.js 3.72 kB +1.72 kB (+86%) 🆘
ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1216.legacy.********************.js 23.9 kB 0 B
dotcom-rendering/dist/1699.modern.********************.js 26.5 kB 0 B
dotcom-rendering/dist/1784.legacy.********************.js 3.81 kB 0 B
dotcom-rendering/dist/1931.legacy.********************.js 4.81 kB 0 B
dotcom-rendering/dist/1954.modern.********************.js 6.7 kB 0 B
dotcom-rendering/dist/208.js 1.99 kB 0 B
dotcom-rendering/dist/2340.legacy.********************.js 5.6 kB 0 B
dotcom-rendering/dist/243.legacy.********************.js 6.16 kB 0 B
dotcom-rendering/dist/243.modern.********************.js 5.96 kB 0 B
dotcom-rendering/dist/2430.legacy.********************.js 3.32 kB 0 B
dotcom-rendering/dist/2513.legacy.********************.js 2.92 kB 0 B
dotcom-rendering/dist/2513.modern.********************.js 2.92 kB 0 B
dotcom-rendering/dist/290.legacy.********************.js 10.3 kB 0 B
dotcom-rendering/dist/290.modern.********************.js 12.1 kB 0 B
dotcom-rendering/dist/2913.legacy.********************.js 6.77 kB 0 B
dotcom-rendering/dist/3039.legacy.********************.js 2.9 kB 0 B
dotcom-rendering/dist/3039.modern.********************.js 2.89 kB 0 B
dotcom-rendering/dist/3206.legacy.********************.js 5.71 kB 0 B
dotcom-rendering/dist/3428.legacy.********************.js 3.75 kB 0 B
dotcom-rendering/dist/3428.modern.********************.js 3.75 kB 0 B
dotcom-rendering/dist/3490.legacy.********************.js 23.8 kB 0 B
dotcom-rendering/dist/3490.modern.********************.js 23.8 kB 0 B
dotcom-rendering/dist/3514.legacy.********************.js 2.96 kB 0 B
dotcom-rendering/dist/3584.legacy.********************.js 1.8 kB 0 B
dotcom-rendering/dist/3584.modern.********************.js 1.8 kB 0 B
dotcom-rendering/dist/3736.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/385.legacy.********************.js 5.29 kB 0 B
dotcom-rendering/dist/385.modern.********************.js 5.29 kB 0 B
dotcom-rendering/dist/3998.legacy.********************.js 3.61 kB 0 B
dotcom-rendering/dist/4356.modern.********************.js 4.68 kB 0 B
dotcom-rendering/dist/4547.legacy.********************.js 4.62 kB 0 B
dotcom-rendering/dist/4547.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/4621.modern.********************.js 4.42 kB 0 B
dotcom-rendering/dist/463.js 10.5 kB 0 B
dotcom-rendering/dist/4734.legacy.********************.js 3.79 kB 0 B
dotcom-rendering/dist/490.js 2.57 kB 0 B
dotcom-rendering/dist/4954.legacy.********************.js 9.14 kB 0 B
dotcom-rendering/dist/4954.modern.********************.js 8.6 kB 0 B
dotcom-rendering/dist/5.js 1.13 kB 0 B
dotcom-rendering/dist/5001.modern.********************.js 20.6 kB 0 B
dotcom-rendering/dist/5481.legacy.********************.js 3.45 kB 0 B
dotcom-rendering/dist/5481.modern.********************.js 3.43 kB 0 B
dotcom-rendering/dist/5491.legacy.********************.js 3.28 kB 0 B
dotcom-rendering/dist/5578.legacy.********************.js 5.12 kB +10 B (0%)
dotcom-rendering/dist/5578.modern.********************.js 5.07 kB +14 B (0%)
dotcom-rendering/dist/5633.legacy.********************.js 6.83 kB 0 B
dotcom-rendering/dist/5715.modern.********************.js 5.46 kB 0 B
dotcom-rendering/dist/5814.legacy.********************.js 3.79 kB 0 B
dotcom-rendering/dist/5821.modern.********************.js 5.36 kB 0 B
dotcom-rendering/dist/5888.modern.********************.js 4.61 kB 0 B
dotcom-rendering/dist/5951.legacy.********************.js 3.79 kB 0 B
dotcom-rendering/dist/598.legacy.********************.js 3.69 kB 0 B
dotcom-rendering/dist/598.modern.********************.js 3.38 kB 0 B
dotcom-rendering/dist/6053.legacy.********************.js 4.62 kB 0 B
dotcom-rendering/dist/6053.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/6131.legacy.********************.js 4.3 kB 0 B
dotcom-rendering/dist/6131.modern.********************.js 4.3 kB 0 B
dotcom-rendering/dist/6214.legacy.********************.js 6.45 kB 0 B
dotcom-rendering/dist/6214.modern.********************.js 6.45 kB 0 B
dotcom-rendering/dist/6219.modern.********************.js 8.37 kB 0 B
dotcom-rendering/dist/6544.modern.********************.js 4.51 kB 0 B
dotcom-rendering/dist/6589.legacy.********************.js 7.45 kB 0 B
dotcom-rendering/dist/684.legacy.********************.js 7.1 kB 0 B
dotcom-rendering/dist/684.modern.********************.js 7.1 kB 0 B
dotcom-rendering/dist/6881.legacy.********************.js 6.08 kB 0 B
dotcom-rendering/dist/6881.modern.********************.js 5.57 kB 0 B
dotcom-rendering/dist/7170.modern.********************.js 6.45 kB 0 B
dotcom-rendering/dist/7185.legacy.********************.js 3.56 kB 0 B
dotcom-rendering/dist/7185.modern.********************.js 3.53 kB 0 B
dotcom-rendering/dist/7458.legacy.********************.js 4.18 kB 0 B
dotcom-rendering/dist/7460.modern.********************.js 6.66 kB 0 B
dotcom-rendering/dist/7576.legacy.********************.js 10.1 kB 0 B
dotcom-rendering/dist/7576.modern.********************.js 8.55 kB 0 B
dotcom-rendering/dist/7585.legacy.********************.js 5.32 kB +1 B (0%)
dotcom-rendering/dist/7585.modern.********************.js 5.28 kB 0 B
dotcom-rendering/dist/7635.legacy.********************.js 2.81 kB 0 B
dotcom-rendering/dist/7635.modern.********************.js 3.42 kB 0 B
dotcom-rendering/dist/764.legacy.********************.js 6.77 kB 0 B
dotcom-rendering/dist/7800.legacy.********************.js 11.3 kB 0 B
dotcom-rendering/dist/7800.modern.********************.js 11.3 kB 0 B
dotcom-rendering/dist/7812.modern.********************.js 4.2 kB 0 B
dotcom-rendering/dist/7829.modern.********************.js 3.4 kB 0 B
dotcom-rendering/dist/7956.modern.********************.js 6.83 kB 0 B
dotcom-rendering/dist/8140.legacy.********************.js 9.19 kB 0 B
dotcom-rendering/dist/8227.legacy.********************.js 3.75 kB 0 B
dotcom-rendering/dist/8227.modern.********************.js 3.73 kB 0 B
dotcom-rendering/dist/8255.legacy.********************.js 3.5 kB 0 B
dotcom-rendering/dist/8558.legacy.********************.js 5.22 kB 0 B
dotcom-rendering/dist/8558.modern.********************.js 5.49 kB 0 B
dotcom-rendering/dist/8829.legacy.********************.js 2.98 kB 0 B
dotcom-rendering/dist/8995.modern.********************.js 5.31 kB 0 B
dotcom-rendering/dist/9030.modern.********************.js 3.97 kB 0 B
dotcom-rendering/dist/9151.legacy.********************.js 4.33 kB 0 B
dotcom-rendering/dist/9259.modern.********************.js 5.62 kB 0 B
dotcom-rendering/dist/938.js 9 kB 0 B
dotcom-rendering/dist/9393.legacy.********************.js 4.19 kB 0 B
dotcom-rendering/dist/9394.legacy.********************.js 5.03 kB 0 B
dotcom-rendering/dist/9614.legacy.********************.js 21.6 kB 0 B
dotcom-rendering/dist/9661.modern.********************.js 3.79 kB 0 B
dotcom-rendering/dist/9751.legacy.********************.js 5.89 kB 0 B
dotcom-rendering/dist/9789.legacy.********************.js 8.54 kB +1 B (0%)
dotcom-rendering/dist/9789.modern.********************.js 8.31 kB -1 B (0%)
dotcom-rendering/dist/9861.modern.********************.js 6.21 kB 0 B
dotcom-rendering/dist/9909.legacy.********************.js 4.8 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.legacy.********************.js 5.72 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 5.72 kB 0 B
dotcom-rendering/dist/atomIframe.legacy.********************.js 13.5 kB 0 B
dotcom-rendering/dist/atomIframe.modern.********************.js 13.4 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.legacy.********************.js 524 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 485 B 0 B
dotcom-rendering/dist/bootCmp.legacy.********************.js 36.9 kB 0 B
dotcom-rendering/dist/bootCmp.modern.********************.js 33.1 kB 0 B
dotcom-rendering/dist/Branding-importable.legacy.********************.js 7.89 kB 0 B
dotcom-rendering/dist/Branding-importable.modern.********************.js 7.88 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.legacy.********************.js 36.9 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.legacy.********************.js 9.11 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 8.1 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.legacy.********************.js 4.8 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 4.58 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.legacy.********************.js 5.85 kB 0 B
dotcom-rendering/dist/Carousel-importable.legacy.********************.js 4.77 kB 0 B
dotcom-rendering/dist/Carousel-importable.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.legacy.********************.js 284 B 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 275 B 0 B
dotcom-rendering/dist/CommentCount-importable.legacy.********************.js 3.95 kB 0 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.92 kB 0 B
dotcom-rendering/dist/CommercialMetrics-importable.legacy.********************.js 3.52 kB 0 B
dotcom-rendering/dist/CommercialMetrics-importable.modern.********************.js 3.49 kB 0 B
dotcom-rendering/dist/CoreVitals-importable.legacy.********************.js 3.62 kB 0 B
dotcom-rendering/dist/CoreVitals-importable.modern.********************.js 3.07 kB 0 B
dotcom-rendering/dist/debug.js 1.75 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.legacy.********************.js 3.87 kB -3 B (0%)
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 3.61 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 2.21 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.legacy.********************.js 1.67 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 1.59 kB 0 B
dotcom-rendering/dist/dynamicImport.legacy.********************.js 22 kB 0 B
dotcom-rendering/dist/dynamicImport.modern.********************.js 21.6 kB 0 B
dotcom-rendering/dist/EditionDropdown-importable.legacy.********************.js 2.36 kB 0 B
dotcom-rendering/dist/EditionDropdown-importable.modern.********************.js 4.53 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.legacy.********************.js 4.35 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.15 kB 0 B
dotcom-rendering/dist/embedIframe.legacy.********************.js 13.5 kB 0 B
dotcom-rendering/dist/embedIframe.modern.********************.js 13.4 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.legacy.********************.js 7.22 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 6.66 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.legacy.********************.js 7.52 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 6.99 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.legacy.********************.js 2.76 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 2.71 kB 0 B
dotcom-rendering/dist/FilterButton-importable.legacy.********************.js 2.94 kB 0 B
dotcom-rendering/dist/FilterButton-importable.modern.********************.js 2.35 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.legacy.********************.js 795 B +1 B (0%)
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 758 B 0 B
dotcom-rendering/dist/FocusStyles-importable.legacy.********************.js 4.73 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 4.67 kB 0 B
dotcom-rendering/dist/ga.legacy.********************.js 20 kB 0 B
dotcom-rendering/dist/ga.modern.********************.js 19.3 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.legacy.********************.js 2.17 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 2.1 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.legacy.********************.js 7.83 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 7.71 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.legacy.********************.js 5.36 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 4.58 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.legacy.********************.js 2.92 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.83 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.legacy.********************.js 11.8 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 11.6 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.********************.js 10.1 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 9.75 kB -50 B (-1%)
dotcom-rendering/dist/GuideAtomWrapper-importable.legacy.********************.js 285 B 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 277 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.legacy.********************.js 9.96 kB 0 B
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.9 kB 0 B
dotcom-rendering/dist/initDiscussion.legacy.********************.js 32.1 kB +59 B (0%)
dotcom-rendering/dist/initDiscussion.modern.********************.js 29.1 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.legacy.********************.js 5.84 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 4.75 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.legacy.********************.js 4.53 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 4.37 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.legacy.********************.js 7.21 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 6.61 kB 0 B
dotcom-rendering/dist/islands.legacy.********************.js 33 kB 0 B
dotcom-rendering/dist/islands.modern.********************.js 29.6 kB +30 B (0%)
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 1.98 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.legacy.********************.js 289 B 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 281 B 0 B
dotcom-rendering/dist/LabsHeader-importable.legacy.********************.js 5.22 kB 0 B
dotcom-rendering/dist/LabsHeader-importable.modern.********************.js 5.51 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.legacy.********************.js 2.03 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 1.97 kB 0 B
dotcom-rendering/dist/Liveness-importable.legacy.********************.js 7.3 kB -2 B (0%)
dotcom-rendering/dist/Liveness-importable.modern.********************.js 6.33 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.legacy.********************.js 3.08 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.25 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.legacy.********************.js 4.92 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 4.85 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.legacy.********************.js 7.42 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.3 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.legacy.********************.js 5.63 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 5.4 kB -3 B (0%)
dotcom-rendering/dist/newsletterEmbedIframe.legacy.********************.js 12.4 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 12.4 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.legacy.********************.js 7.89 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 7.59 kB 0 B
dotcom-rendering/dist/ophan.legacy.********************.js 24.9 kB 0 B
dotcom-rendering/dist/ophan.modern.********************.js 24.1 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.legacy.********************.js 291 B 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 284 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.legacy.********************.js 284 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 276 B 0 B
dotcom-rendering/dist/PulsingDot-importable.legacy.********************.js 2.31 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.modern.********************.js 1.7 kB 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.legacy.********************.js 283 B 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 275 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.legacy.********************.js 4.64 kB 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 4.63 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.legacy.********************.js 3.97 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.64 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.legacy.********************.js 5.92 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.56 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.legacy.********************.js 5.7 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/relativeTime.legacy.********************.js 12.5 kB 0 B
dotcom-rendering/dist/relativeTime.modern.********************.js 12.1 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.legacy.********************.js 5.26 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.81 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.legacy.********************.js 3.1 kB +2 B (0%)
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.8 kB 0 B
dotcom-rendering/dist/sentry.legacy.********************.js 791 B 0 B
dotcom-rendering/dist/sentry.modern.********************.js 789 B 0 B
dotcom-rendering/dist/sentryLoader.legacy.********************.js 37.7 kB 0 B
dotcom-rendering/dist/sentryLoader.modern.********************.js 33.6 kB 0 B
dotcom-rendering/dist/SetABTests-importable.legacy.********************.js 5.66 kB 0 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 5.64 kB 0 B
dotcom-rendering/dist/ShareCount-importable.legacy.********************.js 1.64 kB 0 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 1.62 kB 0 B
dotcom-rendering/dist/shimport.legacy.********************.js 9.53 kB 0 B
dotcom-rendering/dist/shimport.modern.********************.js 6.87 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.legacy.********************.js 1.64 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 1.07 kB 0 B
dotcom-rendering/dist/ShowMore-importable.legacy.********************.js 6.53 kB -61 B (-1%)
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 6.48 kB -33 B (-1%)
dotcom-rendering/dist/SignInGateMain.legacy.********************.js 5.21 kB 0 B
dotcom-rendering/dist/SignInGateMain.modern.********************.js 4.92 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.legacy.********************.js 4.43 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 4.14 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.legacy.********************.js 3.03 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 4.56 kB 0 B
dotcom-rendering/dist/Snow-importable.legacy.********************.js 7.18 kB 0 B
dotcom-rendering/dist/Snow-importable.modern.********************.js 6.6 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.legacy.********************.js 3 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.legacy.********************.js 8.58 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 9.59 kB 0 B
dotcom-rendering/dist/SubNav-importable.legacy.********************.js 3.65 kB 0 B
dotcom-rendering/dist/SubNav-importable.modern.********************.js 3.06 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.legacy.********************.js 5.88 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.51 kB 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.legacy.********************.js 284 B 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 276 B 0 B
dotcom-rendering/dist/TopicFilterBank-importable.legacy.********************.js 1.76 kB 0 B
dotcom-rendering/dist/TopicFilterBank-importable.modern.********************.js 1.7 kB 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.legacy.********************.js 1.98 kB 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 1.98 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.legacy.********************.js 826 B 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 833 B 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.legacy.********************.js 5.85 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 4.76 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.legacy.********************.js 3.09 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.27 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.legacy.********************.js 5.64 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 4.52 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.legacy.********************.js 7.05 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 6.76 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Dec 22, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR

Lighthouse tested 2 URLs

⚠️ Budget exceeded for 2 of 10 audits.

Report for Article

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left

Category Status Expected Actual
First Contentful Paint ✅ 1500 1432
Largest Contentful Paint ✅ 3000 2004
Time to Interactive ✅ 3500 3109
Cumulative Layout Shift ⚠️ 0.002 0.016917
accessibility ✅ 0.97 1.000000

Report for Front

tested url https://www.theguardian.com/uk

Category Status Expected Actual
First Contentful Paint ✅ 1500 1356
Largest Contentful Paint ✅ 3000 2128
Time to Interactive ✅ 3500 2555
Cumulative Layout Shift ⚠️ 0.002 0.016451
accessibility ✅ 0.97 0.980000

This was referenced Dec 23, 2022
Merged
Merged
Merged
@tkgnm tkgnm changed the title New callout form on dcr Callouts in DCR - PR #4 - Add new CalloutBlockElement Dec 23, 2022
@tkgnm tkgnm changed the title Callouts in DCR - PR #4 - Add new CalloutBlockElement Callouts in DCR - PR 4/5 - Add new CalloutBlockElement Dec 23, 2022
@tkgnm tkgnm mentioned this pull request Dec 23, 2022
Closed
@tkgnm tkgnm changed the base branch from main to add-callout-form-dcr January 3, 2023 14:56
@tkgnm tkgnm closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophie-macmillan sophie-macmillan sophie-macmillan left review comments

Assignees
No one assigned
Labels
dotcom-rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkgnm @sophie-macmillan