Task 2 Implementation for Simplices #20
Conversation
This implementation is capable of plotting every figure in #Task2.
New approach to plot cell fields in 3D grids along with subtle modifications.
Change single color edges to avoid missing corners.
Codecov Report
@@ Coverage Diff @@
## gsoc2021-master #20 +/- ##
===================================================
+ Coverage 94.11% 94.77% +0.65%
===================================================
Files 1 4 +3
Lines 34 134 +100
===================================================
+ Hits 32 127 +95
- Misses 2 7 +5
Continue to review full report at Codecov.
|
Implement dg_mesh, introduce vertices, add all attributes to plotting functions, remove shading.
New approach to plot 3D grids
src/edges.jl
Outdated
| function Makie.plot!(plot::Edges{<:Tuple{Grid}}) | ||
|
|
||
| # Retrieve plot arguments: | ||
| grid = plot[:grid][] |
There was a problem hiding this comment.
de-referencing the observable with [] will possibly lead to problems in reactive animations.
src/faces.jl
Outdated
| end | ||
| end | ||
| end | ||
| Makie.mesh!(plot, grid_; |
There was a problem hiding this comment.
Hi, @paurierap, I think I am commenting an outdated code... but are you still passing all the list of attributes when you interface to Makie.mesh!, Makie.linesegments! and Makie.scatter!, as done here for Makie.mesh!?
There was a problem hiding this comment.
Hi, @ericneiva, I am still passing a list of attributes. If you know a better way to do it, let me know!
There was a problem hiding this comment.
I just wonder if you can use function ‘with_theme’ to avoid passing all attributes: http://makie.juliaplots.org/stable/theming.html
There was a problem hiding this comment.
Good point! I will give it a look to see if it fits!
End of Task 2 and beginning of Task 3
|
Outdated by issue #23 |
This one's the good one! Implementation of Task 2 for simplices. It's only missing to implement cell field plots for quadrilaterals (or higher polytopes).