Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSOC-Task #4 Refactoring #23

Closed
fverdugo opened this issue Aug 10, 2021 · 3 comments
Closed

GSOC-Task #4 Refactoring #23

fverdugo opened this issue Aug 10, 2021 · 3 comments
Assignees
Labels

Comments

@fverdugo
Copy link
Member

This major refactoring solves these problems:

  • We don't need to expose new recipe names to the user
  • We solve the issue with Grid and Triangulation
@fverdugo
Copy link
Member Author

fverdugo commented Aug 10, 2021

  • Work on branch pr-task4 and abandon pr-task2.
  • Address the TODOs in the source code. In particular, extensible processing of attributes.
  • Move code in src/GridapMakie.jl to src/recipes.jl
  • Implement the shorthand plot(uh)
  • Update the tests according the new API. I.e., replace cells by mesh or plot depending the case.
  • Sensible default values when using plot and mesh.

@fverdugo
Copy link
Member Author

fverdugo commented Aug 18, 2021

  • First version of README.md. Use _readme folder, Literate.jl, etc
    • Tentative static figs (ids in runtests.jl): 1, 11, 12, 111
    • Dynamic figs.
  • Open a PR gsoc_master -> master
  • Write the project description etc in the PR description
    • See examples from last years.
    • Structure
      • Summary of the project
      • Initial state
      • What I have done
      • How I have done it (link to issues, mention slak, weekly meetings)
      • Link to results/examples (README, link to package index)
      • future work
    • Relate it with the issues we have used for the tasks
    • Relate it with the project proposal
    • Open and link issues with future work
      • quads / hexs
      • arrows
      • sections and slices
  • Open PR from pr_task4 to gsoc_master. Once merged, the global PR will be automatically updated.
  • Try to solve pending issues
    • 3D visualization of celldata and fields
    • colorrange

@fverdugo
Copy link
Member Author

Fixed by PR #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants