-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newest vertex bisection in 2D [WIP] #733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writevtk possible for UnstructuredGrid but not for Triangulation
This is almost certainly due to the fact that nvb and longest edge are equivalent for a uniform mesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #709. All tests passing on my machine.
A couple of sticking points that I had:
get_cell_node_ids(grid)
returns a Gridap custom typeTable
. It seems this is not intended to be mutable. However, the algorithm I am using requires changing rows for node_ids. For now I a copying this object to aMatrix
and doing operations on the matrix. However, I also have another branch where I tried to stick with the table until I got stuck on the mutability. This is probably pretty bad for the memory footprint as well./src
and one in/test
. I'm not sure exactly what organizational structure is desired.