-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Full support i18n (i18next) excluding localization services #977
Conversation
- Updated react version (for support react-i18next) - Updated build.sh script
-Has unfixed problems with editor styles
Release i18n localization See merge request platform/GUI/graphiql!1
This reverts merge request !1
Revert "Merge branch 'i18n-http-backend' into 'master'" See merge request platform/GUI/graphiql!2
# Conflicts: # packages/graphiql-examples/index.html # packages/graphiql-examples/package.json # packages/graphiql/locales/en/Toolbar.json # packages/graphiql/locales/en/translation.json # packages/graphiql/locales/ru/Toolbar.json # packages/graphiql/locales/ru/translation.json # packages/graphiql/package.json # packages/graphiql/resources/build.sh # packages/graphiql/src/components/DocExplorer.js # packages/graphiql/src/components/ExecuteButton.js # packages/graphiql/src/components/GraphiQL.js # packages/graphiql/src/components/HistoryQuery.js # packages/graphiql/src/components/QueryHistory.js # packages/graphiql/src/components/ToolbarButton.js # packages/graphiql/src/i18n.js # yarn.lock
This reverts commit 0c2c0bd
Revert "Merge branch 'i18n-codemirror-graphql'" See merge request platform/GUI/graphiql!4
@Xambey this PR is awesome and super welcome! l18n was on our ad-hoc roadmap for GraphiQL 0.x.y and so this is a big chunk you just bit out of it! Sorry for all the code changes in the last two weeks, looking at the diff briefly it looks like you got almost everything. If you need to do a Once you're ready to squash these commits, I'll make them into a |
- babel-plugin-inline-json-import returned
@Xambey do you have time to finish this? If not, I can re-create the PR and pull in the upstream changes, and then if i @ you in the commit messages you'll get contribution credit, is that O.K? |
@IvanGoncharov check this out! maybe you can help us with a Ukrainian translation as well when you get a chance? |
@acao I remember about this PR and i hope to have time to fix all conflicts today / tomorrow. If I don’t have time to do everything today/tomorrow, then I dont mind if you correct them. I have a lot of work right now (10-12 hours 6/7) and there is no time to solve all the problems on weekdays, this PR was also done as part of the work assignment |
@Xambey ok thanks! yeah if you can't get to it no big worries, i know what that's like. My job doesn't even sponsor my OSS work yet, haha! If in 48 hours you haven't been able to get to it I'll get it merged, because this is a huge win for us! Again, thanks for doing this! |
# Conflicts: # .eslintignore # jest.config.js # package.json # packages/codemirror-graphql/package.json # packages/examples/graphiql-cdn/graphiql.css # packages/examples/graphiql-cdn/graphiql.js # packages/graphiql/package.json # packages/graphiql/src/components/DocExplorer/SearchBox.js # packages/graphiql/src/components/DocExplorer/TypeLink.js # packages/graphiql/src/components/GraphiQL.js # packages/graphiql/src/components/__tests__/GraphiQL.spec.js # packages/graphiql/src/utility/mergeAst.js # packages/graphql-language-service-interface/package.json # packages/graphql-language-service-interface/src/GraphQLLanguageService.ts # packages/graphql-language-service-interface/src/getAutocompleteSuggestions.ts # packages/graphql-language-service-interface/src/getDiagnostics.ts # packages/graphql-language-service-interface/src/getHoverInformation.ts # packages/graphql-language-service-interface/src/getOutline.ts # packages/graphql-language-service-parser/package.json # packages/graphql-language-service-server/package.json # packages/graphql-language-service-server/src/GraphQLCache.js # packages/graphql-language-service-server/src/__tests__/GraphQLCache-test.js # packages/graphql-language-service-utils/package.json # packages/graphql-language-service-utils/src/Range.ts # packages/graphql-language-service-utils/src/validateWithCustomRules.ts # packages/graphql-language-service/package.json # resources/runTests.js # resources/util.js # yarn.lock
Merge remote-tracking branch 'origin/master' # Conflicts: # .eslintignore # jest.config.js # package.json # packages/codemirror-graphql/package.json # packages/examples/graphiql-cdn/graphiql.css # packages/examples/graphiql-cdn/graphiql.js # packages/graphiql/package.json # packages/graphiql/src/components/DocExplorer/SearchBox.js # packages/graphiql/src/components/DocExplorer/TypeLink.js # packages/graphiql/src/components/GraphiQL.js # packages/graphiql/src/components/__tests__/GraphiQL.spec.js # packages/graphiql/src/utility/mergeAst.js # packages/graphql-language-service-interface/package.json # packages/graphql-language-service-interface/src/GraphQLLanguageService.ts # packages/graphql-language-service-interface/src/getAutocompleteSuggestions.ts # packages/graphql-language-service-interface/src/getDiagnostics.ts # packages/graphql-language-service-interface/src/getHoverInformation.ts # packages/graphql-language-service-interface/src/getOutline.ts # packages/graphql-language-service-parser/package.json # packages/graphql-language-service-server/package.json # packages/graphql-language-service-server/src/GraphQLCache.js # packages/graphql-language-service-server/src/__tests__/GraphQLCache-test.js # packages/graphql-language-service-utils/package.json # packages/graphql-language-service-utils/src/Range.ts # packages/graphql-language-service-utils/src/validateWithCustomRules.ts # packages/graphql-language-service/package.json # resources/runTests.js # resources/util.js # yarn.lock
@acao everything seems to work, but there may be a problem with not working prompts when entering the editor. This was sometimes observed when building with a locally assembled codemirror-graphql package, please fix it, i don't understand why |
awesome, thank you I’ll check it out here in a few hours
…On Sun, Oct 20, 2019 at 3:51 PM Xambey ***@***.***> wrote:
@acao <https://github.com/acao> everything seems to work, but there may
be a problem with not working prompts when entering the editor. This was
sometimes observed when building with a locally assembled
codemirror-graphql package, please fix it, i don't understand why
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#977?email_source=notifications&email_token=AAKOFF366BX66WZ4KJDFCGTQPSZFXA5CNFSM4I6O3JPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYSKGQ#issuecomment-544285978>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKOFF7BP2YER5IRIEYKNC3QPSZFXANCNFSM4I6O3JPA>
.
|
@Xambey when you refer to non-working prompts, which prompts are you referring to? |
thanks so much for all your work on this @Xambey! this is quite a huge diff it looks like, with a lot of unrelated changes, so I will turn this into a PR that's just the excellent translation/ would love to have your help on some of the other issues this PR addresses soon as well, however with such a widely used project, our changelog needs to be very punctuated and iterative. as @leebyron has instructed, and @IvanGoncharov would agree, and part of what has made the official graphql ecosystem so successful, is, "One step at a time, ship often and prosper" |
I implemented full localization support based on the i18next plugin. Two languages are currently supported:
P.S For verification, don't forget to clear localstorage