feat: Add support for i18n #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshithpabbati
force-pushed
the
i18next
branch
4 times, most recently
from
b91434e to
65b4c50
Compare
|
@acao can you review this ? |
acao
reviewed
May 15, 2020
acao
reviewed
May 15, 2020
acao
reviewed
May 15, 2020
acao
reviewed
May 15, 2020
acao
reviewed
May 15, 2020
| @@ -11,7 +11,7 @@ | |||
| "src/*": ["*"] | |||
| } | |||
| }, | |||
| "include": ["src"], | |||
| "include": ["src", "src/**/*.json"], | |||
There was a problem hiding this comment.
.json files should always be included if resolveJSONModules is enabled, right?
acao
reviewed
May 15, 2020
|
overall, this is looking fantastic! thanks so much @harshithpabbati. really just that one locale line, and finding a way to get the json files to copy over to dist/esm is needed. maybe we can just use also, if you'd like to add another translation in any of the languages you speak, feel free! |
|
ok cool! I will make the required changes. |
Co-authored-by: Xambey <Xambey@yandex.ru>
|
@acao updated the PR |
acao
pushed a commit
that referenced
this pull request
May 16, 2020
acao
pushed a commit
that referenced
this pull request
May 16, 2020
acao
pushed a commit
that referenced
this pull request
May 16, 2020
acao
pushed a commit
that referenced
this pull request
May 16, 2020
acao
pushed a commit
that referenced
this pull request
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @Xambey for your PR.