Create Plugin: Improve handling of e2e in update cmd #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While @Ukochka was updating the plugins in the example repo (see this PR for example), we noticed the
create-plugin update
cmd is not behaving quite the way we want. In case the plugin did not have any e2e tests at all (Playwright nor Cypress), grafana/e2e scripts and deps were added to the package.json file.This PR ensures that cypress specific stuff should only be added to package.json in case:
cypress
folder exist in the plugin root dirWhich issue(s) this PR fixes:
Fixes #919
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.10.5-canary.920.29fa67c.0 # or yarn add @grafana/create-plugin@4.10.5-canary.920.29fa67c.0