-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app-with-service-account and app-with-scenes #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits
"typecheck": "tsc --noEmit" | ||
"typecheck": "tsc --noEmit", | ||
"e2e": "npm exec cypress install && npm exec grafana-e2e run", | ||
"e2e:update": "npm exec cypress install && npm exec grafana-e2e run --update-screenshots" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two scrips
"sign": "npx --yes @grafana/sign-plugin@latest" | ||
"sign": "npx --yes @grafana/sign-plugin@latest", | ||
"e2e": "npm exec cypress install && npm exec grafana-e2e run", | ||
"e2e:update": "npm exec cypress install && npm exec grafana-e2e run --update-screenshots" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two scrips
Think playwright is replaced by grafana/e2e because you're not using the latest version of create plugin. |
"webpack-cli": "^5.1.4", | ||
"webpack-livereload-plugin": "^3.0.2", | ||
"@grafana/e2e": "10.3.3", | ||
"@grafana/e2e-selectors": "10.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.