Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app-with-service-account and app-with-scenes #298

Merged
merged 4 commits into from
May 23, 2024

Conversation

Ukochka
Copy link
Contributor

@Ukochka Ukochka commented May 16, 2024

No description provided.

@Ukochka Ukochka self-assigned this May 16, 2024
@Ukochka Ukochka requested review from a team as code owners May 16, 2024 13:08
@Ukochka Ukochka requested review from sunker, wbrowne, andresmgot and oshirohugo and removed request for a team May 16, 2024 13:08
sunker
sunker previously approved these changes May 23, 2024
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunker sunker dismissed their stale review May 23, 2024 05:37

Missed a few comments

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits

"typecheck": "tsc --noEmit"
"typecheck": "tsc --noEmit",
"e2e": "npm exec cypress install && npm exec grafana-e2e run",
"e2e:update": "npm exec cypress install && npm exec grafana-e2e run --update-screenshots"
Copy link
Contributor

@sunker sunker May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two scrips

"sign": "npx --yes @grafana/sign-plugin@latest"
"sign": "npx --yes @grafana/sign-plugin@latest",
"e2e": "npm exec cypress install && npm exec grafana-e2e run",
"e2e:update": "npm exec cypress install && npm exec grafana-e2e run --update-screenshots"
Copy link
Contributor

@sunker sunker May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two scrips

@sunker
Copy link
Contributor

sunker commented May 23, 2024

Think playwright is replaced by grafana/e2e because you're not using the latest version of create plugin.
Instead if create-plugin update, can you try npx @grafana/create-plugin@latest update and see if the output is any different?

"webpack-cli": "^5.1.4",
"webpack-livereload-plugin": "^3.0.2",
"@grafana/e2e": "10.3.3",
"@grafana/e2e-selectors": "10.3.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two deps

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ukochka Ukochka merged commit de2a341 into main May 23, 2024
24 checks passed
@Ukochka Ukochka deleted the app-with-service-account-and-with-scenes branch May 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants