Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make manifests to update deploy/base/ #968

Merged
merged 10 commits into from
Apr 1, 2023

Conversation

NissesSenap
Copy link
Collaborator

Fixes #960

@NissesSenap NissesSenap requested a review from pb82 March 26, 2023 12:39
@NissesSenap
Copy link
Collaborator Author

Sigh, don't know where I should generate this. Don't like to add kustomize installation to a bunch of places for no good reason....
Will see if I can move some things around to make it better.

@NissesSenap
Copy link
Collaborator Author

@weisdd do you have any good ideas on this.
Currently the PR fails due to i need to add kustomize everywhere.
Of course, I can do that but I will increase build time for no good reason.

But if we don't do this during make manifests there is a big risk of missing updating the kustomization files during on PRs.

bash: line 1: /home/runner/work/grafana-operator/grafana-operator/bin/kustomize: No such file or directory
make: *** [Makefile:59: manifests] Error 127
Error: Process completed with exit code 2.

What do you think is the best way forward?
Or should we come up with some other solution all together?

@NissesSenap NissesSenap force-pushed the kustomize_crd_generation branch from 8acbbea to 8271dd0 Compare April 1, 2023 10:47
@NissesSenap NissesSenap enabled auto-merge (squash) April 1, 2023 11:11
error message should appear on actions dashboard
NissesSenap and others added 2 commits April 1, 2023 18:22
Co-authored-by: Igor Beliakov <46579601+weisdd@users.noreply.github.com>
Co-authored-by: Igor Beliakov <46579601+weisdd@users.noreply.github.com>
@NissesSenap NissesSenap merged commit 2823e3e into grafana:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] jsonnet field missing from GrafanaDashboards CRD in deploy/
2 participants