Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] jsonnet field missing from GrafanaDashboards CRD in deploy/ #960

Closed
robholland opened this issue Mar 24, 2023 · 1 comment · Fixed by #968
Closed

[Bug] jsonnet field missing from GrafanaDashboards CRD in deploy/ #960

robholland opened this issue Mar 24, 2023 · 1 comment · Fixed by #968
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
Version 5.0

Comments

@robholland
Copy link

Describe the bug
The jsonnet field is missing from https://github.com/grafana-operator/grafana-operator/blob/master/deploy/base/crds.yaml#L3848

Version
v5.0.0-rc0

To Reproduce
Steps to reproduce the behavior:

  1. Deploy v5.0.0-rc0
  2. Apply a GrafanaDashboard with jsonnet field.
  3. jsonnet field will be silentely dropped and the operator will complain there is no source type found.

Expected behavior
The dashboard should be successfully synced.

Runtime (please complete the following information):

  • OS: linux
  • Grafana Operator Version: v5.0.0-rc0
  • Environment: Kubernetes
  • Deployment type: deployed
@robholland robholland added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 24, 2023
@pb82
Copy link
Collaborator

pb82 commented Mar 24, 2023

@robholland Thanks for reporting this! I may have forgotten to update the CRDs after we merged the jsonnet support 🤦

NissesSenap added a commit to NissesSenap/grafana-operator that referenced this issue Mar 26, 2023
@NissesSenap
Update make manifests to update deploy/base/
3bac2ae 
Fixes grafana#960
@NissesSenap NissesSenap mentioned this issue Mar 26, 2023
Merged
@NissesSenap NissesSenap added this to the Version 5.0 milestone Mar 26, 2023
@NissesSenap NissesSenap added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 26, 2023
NissesSenap added a commit to NissesSenap/grafana-operator that referenced this issue Apr 1, 2023
@NissesSenap
Update make manifests to update deploy/base/
adbd66e 
Fixes grafana#960
NissesSenap added a commit that referenced this issue Apr 1, 2023
@NissesSenap
Update make manifests to update deploy/base/ (#968)
2823e3e 
Fixes #960
* create a specific make kustomize-crd command
* make all now prepares everything in a PR except running the e2e test
* update pr-validation to check for kustomize-crd
* update contributing.md to match new changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
Version 5.0
Development

Successfully merging a pull request may close this issue.

Update make manifests to update deploy/base/ NissesSenap/grafana-operator
3 participants
@robholland @pb82 @NissesSenap