Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create instance before patching quickstart #397

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jul 2, 2021

Also cleans up old instances and drops the new instance after the test.

Fixes #390 🦕

Also cleans up old instances and drops the new instance after the test.
@skuruppu skuruppu requested review from a team as code owners July 2, 2021 04:45
@skuruppu skuruppu requested review from dandhlee and removed request for a team July 2, 2021 04:45
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@skuruppu skuruppu requested a review from zoercai July 2, 2021 04:46
@skuruppu skuruppu force-pushed the fix-quickstart-test branch from 91248f1 to df804d8 Compare July 2, 2021 05:50
@skuruppu skuruppu force-pushed the fix-quickstart-test branch from df804d8 to 20bd3c2 Compare July 2, 2021 06:07
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Jul 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7363ed4 into googleapis:master Jul 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples.samples.quickstart_test: test_quickstart failed
2 participants