-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples.samples.quickstart_test: test_quickstart failed #390
Comments
commit: f3362fe Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.38.1 gax/1.30.0 gccl/3.6.0')]} |
commit: 1701899 Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.38.1 gax/1.30.0 gccl/3.6.0')]} |
Also cleans up old instances and drops the new instance after the test. Fixes #390 🦕
Looks like this issue is flaky. 😟 I'm going to leave this open and stop commenting. A human should fix and close this. commit: 0f1a5de Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.38.1 gax/1.30.0 gccl/3.6.0')]} |
We've merged in several PRs since this issue was fixed and we have not seen this failure. I imagine that this is from a run where master was not merged in to include the fix. Closing. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 4a0a8e1 Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.38.1 gax/1.30.0 gccl/3.6.0')]} |
I think I know what's going on. This repo is setup in some way where it doesn't actually tell you that the PR is not up-to-date with the master branch. When you trigger test runs, they run at older commits, so even though the underlying test was fixed last Friday, we keep getting this failure. I will have to talk to the repo admins to see how this can be fixed. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 1b04bbf Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.38.1 gax/1.31.0 gccl/3.6.0')]} |
@larkee to follow up with the Python repo owners on what's going on here. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: b0455d0 Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.38.1 gax/1.31.0 gccl/3.6.0')]} |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: b0455d0 Test outputargs = (parent: "projects/python-docs-samples-tests/instances/test-instance" create_statement: "CREATE DATABASE `my-database-id`" ,) kwargs = {'metadata': [('google-cloud-resource-prefix', 'projects/python-docs-samples-tests/instances/test-instance/databases/m...-samples-tests/instances/test-instance'), ('x-goog-api-client', 'gl-python/3.6.13 grpc/1.39.0 gax/1.31.0 gccl/3.6.0')]} |
I don't understand the reported failure, which purports to be running against commit b0455d0. However, the $ git remote -v
origin git@github.com:googleapis/python-spanner (fetch)
origin git@github.com:googleapis/python-spanner (push)
$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
$ git log -1
commit b0455d0ab657cd053a7527e99bdbfadc4de23b30 (HEAD -> master, origin/master, origin/HEAD)
Author: Tres Seaver <tseaver@palladion.com>
Date: Tue Jul 20 15:53:53 2021 -0400
fix(deps): pin 'google-{api,cloud}-core' to allow 2.x versions (#415)
Include comment on embargo of '>= 2.x' min versions
Per: https://github.com/googleapis/google-cloud-python/issues/10566
$
$ git grep example_database || echo "Not Found" Looking upward in the log, I see the following:
I don't understand the benefit of testing samples against old commits in the periodic job. @tmatsuo I think you added that bit in the synthool template (PR googleapis/synthtool#992) -- can you elaborate here? The failure is in the test infrastructure, not in the actual library code or the sample itself, and is fixed on |
I guess this issue will be closed by merging the next release PR (#398). |
This test failed!
To configure my behavior, see the Flaky Bot documentation.
If I'm commenting on this issue too often, add the
flakybot: quiet
label andI will stop commenting.
commit: 3132587
buildURL: Build Status, Sponge
status: failed
Test output
The text was updated successfully, but these errors were encountered: