Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New vim-job based CallAsync doesn't handle complex commands correctly #205

Closed
ardagnir opened this issue May 1, 2017 · 0 comments
Closed

New vim-job based CallAsync doesn't handle complex commands correctly #205

ardagnir opened this issue May 1, 2017 · 0 comments
Assignees
@dbarnett

Comments

@ardagnir
Copy link
Contributor

ardagnir commented May 1, 2017

It looks like the new job version of CallAsync is breaking up commands incorrectly.

Example of broken behavior:
let g:command = maktaba#syscall#Create(['echo', 'a']).And(['echo','b'])

g:command.Call (and CallAsync with vim jobs disabled) gives the correct stdout of "a\nb"
with vim jobs, g:command.CallAsync gives the incorrect stdout of "a && echo b"
ardagnir added a commit to ardagnir/vim-maktaba that referenced this issue May 2, 2017
@ardagnir
Use shell for CallAsync with vim jobs
da6d6b1 
syscall functions assume shell-like behavior, but job_start doesn't use
a shell.

Fixes google#205
ardagnir added a commit to ardagnir/vim-maktaba that referenced this issue May 2, 2017
@ardagnir
Use shell for CallAsync with vim jobs
e8660bf 
syscall functions assume shell-like behavior, but job_start doesn't use
a shell.

Fixes google#205
ardagnir added a commit to ardagnir/vim-maktaba that referenced this issue May 2, 2017
@ardagnir
Use shell for CallAsync with vim jobs
8a51ace 
syscall functions assume shell-like behavior, but job_start doesn't use
a shell.

Fixes google#205
ardagnir added a commit to ardagnir/vim-maktaba that referenced this issue May 2, 2017
@ardagnir
Use shell for CallAsync with vim jobs
bcb87c7 
syscall functions assume shell-like behavior, but job_start doesn't use
a shell.

Fixes google#205
ardagnir added a commit to ardagnir/vim-maktaba that referenced this issue May 2, 2017
@ardagnir
Use shell for CallAsync with vim jobs
1e5f7e6 
syscall functions assume shell-like behavior, but job_start doesn't use
a shell.

Fixes google#205
@ardagnir ardagnir mentioned this issue May 2, 2017
Merged
dbarnett added a commit that referenced this issue May 8, 2017
@dbarnett
Bump version to 1.15.0
2ae8b44 
Changes since 1.14.0:
  * Implement maktaba#buffer#GetVisualSelection helper (#132).
  * Implement maktaba#log#GetFormattedEntries and support 1-arg log
    handler (see #204).
  * Notify user for messages logged at WARN or above by default (#185).
  * Fix Syscall.CallAsync failing for complex commands (#205).
  * Preserve trailing slash in maktaba#path#Split and MakeRelative
    (#137 and #175).
  * Fix 'maxfuncdepth' error in maktaba#json#Parse corner case (#153).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbarnett dbarnett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbarnett @ardagnir