Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger.Warn and above should display incoming messages to user #185

Closed
dbarnett opened this issue Mar 25, 2017 · 0 comments
Closed

Logger.Warn and above should display incoming messages to user #185

dbarnett opened this issue Mar 25, 2017 · 0 comments
Labels
enhancement

Comments

@dbarnett
Copy link
Contributor

If a plugin logs a warning or error to maktaba's logging mechanism, it should also be displayed to the user using echomsg. The alternative would be for plugin authors to both log and display errors, but that's less convenient and not configurable. Also users could end up seeing duplicate warnings if there's confusion about who's responsible for displaying the errors.
This was referenced Mar 25, 2017
Open
Merged
dbarnett added a commit that referenced this issue May 8, 2017
@dbarnett
Bump version to 1.15.0
2ae8b44 
Changes since 1.14.0:
  * Implement maktaba#buffer#GetVisualSelection helper (#132).
  * Implement maktaba#log#GetFormattedEntries and support 1-arg log
    handler (see #204).
  * Notify user for messages logged at WARN or above by default (#185).
  * Fix Syscall.CallAsync failing for complex commands (#205).
  * Preserve trailing slash in maktaba#path#Split and MakeRelative
    (#137 and #175).
  * Fix 'maxfuncdepth' error in maktaba#json#Parse corner case (#153).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbarnett