Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tables whose msgstr is a specific type of HTML #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shinmili
Copy link

@shinmili shinmili commented Feb 8, 2025

If an msgstr for a table cell contains HTML that could be parsed as an HTML block if it were put in the top-level, the table is rendered incorrectly. The table row containing the cell gets interrupted in the middle and split into two (or more, if there are more such cells) incomplete rows.

Close #251.

If an msgstr for a table cell contains HTML that could be parsed as an
HTML block if it were put in the top-level, the table is rendered
incorrectly. The table row containing the cell gets interrupted in the
middle and split into two (or more, if there are more such cells)
incomplete rows.

Close google#251.
Copy link

google-cla bot commented Feb 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (886f15e) to head (f9ae9a6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
i18n-helpers/src/lib.rs 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   84.74%   85.37%   +0.62%     
==========================================
  Files          15       16       +1     
  Lines        3377     3527     +150     
  Branches     3377     3527     +150     
==========================================
+ Hits         2862     3011     +149     
+ Misses        413      412       -1     
- Partials      102      104       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken table with <img> tag
2 participants