Add instructions for sanitizer integration #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention that none of these hooks is particularly well-documented. I found the ASAN one via https://github.com/llvm-mirror/compiler-rt/blob/master/include/sanitizer/asan_interface.h#L263, but the others don't appear in the related headers, so I had to check e.g. |
|
@asoffer Any feedback? It looks like I can't actually assign reviewers to the PR. Thanks! |
|
Looks good to me. Pulling this in internally now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3083 for context. This PR adds specific instructions for how to trigger test failures when sanitizers including UBSan, ASan, and TSan report errors.