-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI fail if sanitizers find errors #477
Labels
class::bug
Bugs found in the software
loc::backend
This issue concerns the C++ backend implementation.
loc::continuous integration
This issue concerns any problem of continuous integration.
Comments
This was referenced Nov 27, 2022
Closed
17 tasks
17 tasks
I just found that the integration is also documented here: https://google.github.io/googletest/advanced.html |
Repository owner
moved this from 🏗 Development
to ✅ Done (Sprint)
in MEmilio: Equation-Based-Models
Dec 8, 2022
Repository owner
moved this from Development
to Done (Sprint)
in MEmilio: Agent-Based-Model
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
class::bug
Bugs found in the software
loc::backend
This issue concerns the C++ backend implementation.
loc::continuous integration
This issue concerns any problem of continuous integration.
If address or undefined behavior sanitizers report errors, we currently break the program
fno-sanitize-recover=all
See: https://github.com/DLR-SC/memilio/blob/main/cpp/CMakeLists.txt#L55-L56
For documentation of sanitizers see https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html or https://clang.llvm.org/docs/AddressSanitizer.html
However, in these cases, googletest does not recognize a test where the sanitizer recently reported an error
as failed and gave a green "OK" sign in the github UI.
In order to have correct test reporting, we can take google/googletest#3086
The text was updated successfully, but these errors were encountered: