Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task debugging. #4343

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Improve task debugging. #4343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/clusterfuzz/_internal/bot/tasks/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ def process_command_impl(task_name,
# A misconfiguration led to this point. Clean up the job if necessary.
# TODO(ochang): Remove the first part of this check once we migrate off the
# old untrusted worker architecture.
# Comment this "if" out to run a task locally.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What situation should I comment this in? I was able to run fuzz task locally without touching this

Copy link
Collaborator Author

@jonathanmetzman jonathanmetzman Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do remember things hanging when running tasks on my own machine because of this block. I'll have to run it without this and find out.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is indeed true. I take that back

if (not environment.is_trusted_host(ensure_connected=False) and
if (not environment.get_value('DEBUG_TASK') and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need for parens here, since AND is commutative

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's for formatting.

not environment.is_trusted_host(ensure_connected=False) and
job_base_queue_suffix != bot_base_queue_suffix):
# This happens rarely, store this as a hard exception.
logs.error('Wrong platform for job %s: job queue [%s], bot queue [%s].' %
Expand Down
Loading