Improve task debugging. #4343
Merged
Improve task debugging. #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an env var so we don't need to comment out code.
vitorguidi
reviewed
Oct 21, 2024
| @@ -285,8 +285,8 @@ def process_command_impl(task_name, | |||
| # A misconfiguration led to this point. Clean up the job if necessary. | |||
| # TODO(ochang): Remove the first part of this check once we migrate off the | |||
| # old untrusted worker architecture. | |||
| # Comment this "if" out to run a task locally. | |||
| if (not environment.is_trusted_host(ensure_connected=False) and | |||
| if (not environment.get_value('DEBUG_TASK') and | |||
There was a problem hiding this comment.
nit: no need for parens here, since AND is commutative
There was a problem hiding this comment.
I think it's for formatting.
vitorguidi
reviewed
Oct 21, 2024
| @@ -285,8 +285,8 @@ def process_command_impl(task_name, | |||
| # A misconfiguration led to this point. Clean up the job if necessary. | |||
| # TODO(ochang): Remove the first part of this check once we migrate off the | |||
| # old untrusted worker architecture. | |||
| # Comment this "if" out to run a task locally. | |||
There was a problem hiding this comment.
What situation should I comment this in? I was able to run fuzz task locally without touching this
There was a problem hiding this comment.
I do remember things hanging when running tasks on my own machine because of this block. I'll have to run it without this and find out.
There was a problem hiding this comment.
Yeah, that is indeed true. I take that back
vitorguidi
added a commit
that referenced
this pull request
Nov 13, 2024
### Motivation We currently lack awareness on how old builds are during fuzz task. This PR implements that, by making the assumption that the Last Update Time metadata field in GCS is a good proxy for build age. [Documentation reference](https://cloud.google.com/storage/docs/json_api/v1/objects#resource) ### Approach Symbolized and custom builds do not matter, thus all builds of interest will be fetched from ```build_manager.setup_regular_build```. Logic for collecting all bucket paths and the latest revision was refactored, so that ```setup_regular_build``` can also figure out the latest revision for a given build and conditionally emit the proposed metric. ### Testing strategy !Todo: test this for fuzz, analyze, progression Locally ran tasks, with instructions from #4343 and #4345 , and verified the _emmit_build_age_metric function gets invoked and produces sane output. Commands used: ``` fuzz libFuzzer libfuzzer_asan_log4j2 ```  ``` progression 4992158360403968 libfuzzer_asan_qt ```  ``` analyze 4992158360403968 libfuzzer_asan_qt (disclaimer: build revision was overriden mid flight to force a trunk build, since this testcase was already tied to a crash revision) ```  Part of #4271
vitorguidi
added a commit
that referenced
this pull request
Nov 21, 2024
### Motivation We currently lack awareness on how old builds are during fuzz task. This PR implements that, by making the assumption that the Last Update Time metadata field in GCS is a good proxy for build age. [Documentation reference](https://cloud.google.com/storage/docs/json_api/v1/objects#resource) ### Approach Symbolized and custom builds do not matter, thus all builds of interest will be fetched from ```build_manager.setup_regular_build```. Logic for collecting all bucket paths and the latest revision was refactored, so that ```setup_regular_build``` can also figure out the latest revision for a given build and conditionally emit the proposed metric. ### Testing strategy !Todo: test this for fuzz, analyze, progression Locally ran tasks, with instructions from #4343 and #4345 , and verified the _emmit_build_age_metric function gets invoked and produces sane output. Commands used: ``` fuzz libFuzzer libfuzzer_asan_log4j2 ```  ``` progression 4992158360403968 libfuzzer_asan_qt ```  ``` analyze 4992158360403968 libfuzzer_asan_qt (disclaimer: build revision was overriden mid flight to force a trunk build, since this testcase was already tied to a crash revision) ```  Part of #4271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an env var so we don't need to comment out code.