add google api expr #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
thanks |
|
For context: we want to use 1.3.0 gogoprotobuf in envoyproxy/go-control-plane. This is one of the missing dependencies. |
|
@kyessenov Thanks a lot for working on this. Hopefully we can merge this next week. |
|
@kyessenov just checking whether we are just waiting for approval or do we have a dependency to merge this ? |
|
Waiting for approval :) |
|
@awalterschulze @johanbrandhorst Can we please get a review on this one please. |
|
Hey, sorry, for some reason I haven't got notifications turned on for this repo. Sorry for the delay! |
johanbrandhorst
approved these changes
Sep 14, 2019
|
@kyessenov @johanbrandhorst Thanks for helping with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com