Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-plane-api 7818642b2294cee404137a8fb97b65cba89d1b2d #221

Closed
wants to merge 1 commit into from

Conversation

dschaller
Copy link
Member

No description provided.

Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
Copy link
Contributor

@yangminzhu yangminzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you follow https://github.com/envoyproxy/go-control-plane#quick-start to also update the generated code?

@kyessenov
Copy link
Contributor

There's some work done to clean up dependency on istio/gogo-genproto. That dependency moved to use an unreleased version of gogoprotobuf and causing issues.

@dschaller
Copy link
Member Author

Yeah I noticed that this is an issue. We should probably figure out a longer term solution for things like this since we are making breaking changes into an upstream project before the downstream projects can build properly.

@kyessenov
Copy link
Contributor

kyessenov commented Sep 6, 2019

Longer term we should use golang/protobuf. See #213

@kyessenov
Copy link
Contributor

Ref gogo/googleapis#7

@jyotimahapatra
Copy link
Contributor

jyotimahapatra commented Sep 11, 2019

@mattklein123 fyi. In order to update the data-plane-api, we need gogo/googleapis#7 and a subsequent fix to use the googleapis instead of istio in go-control-plane.

@jyotimahapatra
Copy link
Contributor

@kyessenov Looks like the data-plane-api submodule is now removed. and the generate_proto.sh has been removed too.
We want to use the lates go-control-plane in our control plane to deal with few new deprecated fields.
Is there a new version of go-control-plane now that we can use?

@kyessenov
Copy link
Contributor

Master is using golang/protobuf, which I strongly suggest to start using if you plan to build a new control plane.

@dschaller dschaller closed this Sep 16, 2019
@jyotimahapatra
Copy link
Contributor

Thanks @kyessenov . I will move our control plane to use master.

@dschaller dschaller deleted the update-dataplaneapi branch September 16, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants