-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-plane-api 7818642b2294cee404137a8fb97b65cba89d1b2d #221
Conversation
Signed-off-by: Derek Schaller <d_a_schaller@yahoo.com>
56bbde9
to
72af09a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you follow https://github.com/envoyproxy/go-control-plane#quick-start to also update the generated code?
There's some work done to clean up dependency on istio/gogo-genproto. That dependency moved to use an unreleased version of gogoprotobuf and causing issues. |
Yeah I noticed that this is an issue. We should probably figure out a longer term solution for things like this since we are making breaking changes into an upstream project before the downstream projects can build properly. |
Longer term we should use golang/protobuf. See #213 |
@mattklein123 fyi. In order to update the data-plane-api, we need gogo/googleapis#7 and a subsequent fix to use the googleapis instead of istio in go-control-plane. |
@kyessenov Looks like the data-plane-api submodule is now removed. and the |
Master is using golang/protobuf, which I strongly suggest to start using if you plan to build a new control plane. |
Thanks @kyessenov . I will move our control plane to use master. |
No description provided.