-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add texture property accessors that are missing to comply with webgpu.h #3740
Conversation
Since Having to do per wgpu-hal backend implementations seems unnecessarily complicated & repetetive, after all it seems that there's many many more properites that need querying: https://github.com/gfx-rs/wgpu-native/blob/trunk/src/unimplemented.rs#L245-L284 |
Okey thanks for the feedback! This makes me understand better the overall organization of the code... and realize that the descriptor is already stored within the texture object, so the change becomes very simple :) Will add other simple getters. |
Here we are with all missing accessors! Some questions:
Besides these, should be ready to merge. |
The reason we lifted the descriptor storing into |
Okey, not sure I understand what the action should be for me in the end (sorry still new to this code base). Do you mean that I should not use |
This was implemented completely in |
Nice, in that case we can close this off on this side |
I am looking at the way to implement missing bits of
wgpu-native
likewgpuTextureGetWidth
as a way to get started withwgpu
code base.This PR is not ready yet, but I would love to get some feedback about the first steps so that I know whether I am going in the right direction!