Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement some new functions & some minor fixes #265

Merged
merged 4 commits into from
May 29, 2023
Merged

implement some new functions & some minor fixes #265

merged 4 commits into from
May 29, 2023

Conversation

rajveermalviya
Copy link
Collaborator

Changes

  • RwLock for logger info instead of Mutex
  • better mapping for adapter properties
  • implement wgpuQueueOnSubmittedWorkDone
  • implement getters for Buffer & Texture metadata.

Testing

tested examples on linux

@rajveermalviya rajveermalviya requested a review from almarklein May 25, 2023 10:53
@rajveermalviya
Copy link
Collaborator Author

@almarklein ping

almarklein
almarklein approved these changes May 28, 2023
View reviewed changes
Copy link
Collaborator

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see how unimplemented.rs gets smaller and smaller 👍

@rajveermalviya rajveermalviya merged commit 6f95ce3 into gfx-rs:trunk May 29, 2023
@rajveermalviya rajveermalviya deleted the misc branch May 29, 2023 07:52
@rajveermalviya rajveermalviya mentioned this pull request May 29, 2023
Closed
This was referenced Jun 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almarklein almarklein almarklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajveermalviya @almarklein