-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Remove sentry_sdk.configure_scope
#3406
feat(api): Remove sentry_sdk.configure_scope
#3406
Conversation
sentry_sdk.configure_scope
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 12169 tests with View the full list of failed testspy3.11-strawberry-latest
py3.11-strawberry-v0.209
py3.12-strawberry-latest
py3.12-strawberry-v0.222
py3.8-strawberry-latest
py3.8-strawberry-v0.209
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Strawberry will then not be compatible with the new SDK anymore, because they use configure_scope in their sentry extension:
https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/extensions/tracing/sentry.py
I am going to see if there is anything we can do here about this, or perhaps we need to submit a PR upstream |
Also, remove any tests for `sentry_sdk.configure_scope`. Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`. BREAKING CHANGE: Remove `sentry_sdk.configure_scope`. Closes: #3402
62560f3
to
73a66ab
Compare
@antonpirker looks like only Strawberry's Sentry tracing extensions will be incompatible – everything else from Strawberry still works. I removed the imports of those extensions and any functionality based on them; that way, the tests should pass. I will also open an issue in Strawberry's repo to let them know we are dropping support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Also, remove any tests for `sentry_sdk.configure_scope`. Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`. BREAKING CHANGE: Remove `sentry_sdk.configure_scope`. Closes: #3402
Also, remove any tests for
sentry_sdk.configure_scope
.Since Strawberry's deprecated Sentry tracing extensions import
sentry_sdk.configure_scope
, importingstrawberry.extensions.tracing.SentryTracingExtension
(orSentryTracingExtensionSync
) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal ofsentry_sdk.configure_scope
.BREAKING CHANGE: Remove
sentry_sdk.configure_scope
.Closes: #3402