Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Remove sentry_sdk.configure_scope #3406

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Aug 7, 2024

Also, remove any tests for sentry_sdk.configure_scope.

Since Strawberry's deprecated Sentry tracing extensions import sentry_sdk.configure_scope, importing strawberry.extensions.tracing.SentryTracingExtension (or SentryTracingExtensionSync) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of sentry_sdk.configure_scope.

BREAKING CHANGE: Remove sentry_sdk.configure_scope.

Closes: #3402

@szokeasaurusrex szokeasaurusrex changed the base branch from master to potel-base August 7, 2024 11:27
@szokeasaurusrex szokeasaurusrex changed the title szokeasaurusrex/remove configure scope feat(api): Remove sentry_sdk.configure_scope Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 12169 tests with 6 failed, 10543 passed and 1620 skipped.

View the full list of failed tests

py3.11-strawberry-latest

  • Class name:
    Test name: tests.integrations.strawberry.test_strawberry

    No failure message available

py3.11-strawberry-v0.209

  • Class name:
    Test name: tests.integrations.strawberry.test_strawberry

    No failure message available

py3.12-strawberry-latest

  • Class name:
    Test name: tests.integrations.strawberry.test_strawberry

    No failure message available

py3.12-strawberry-v0.222

  • Class name:
    Test name: tests.integrations.strawberry.test_strawberry

    No failure message available

py3.8-strawberry-latest

  • Class name:
    Test name: tests.integrations.strawberry.test_strawberry

    No failure message available

py3.8-strawberry-v0.209

  • Class name:
    Test name: tests.integrations.strawberry.test_strawberry

    No failure message available

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Strawberry will then not be compatible with the new SDK anymore, because they use configure_scope in their sentry extension:
https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/extensions/tracing/sentry.py

@szokeasaurusrex
Copy link
Member Author

Strawberry will then not be compatible with the new SDK anymore, because they use configure_scope in their sentry extension:
https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/extensions/tracing/sentry.py

I am going to see if there is anything we can do here about this, or perhaps we need to submit a PR upstream

@szokeasaurusrex szokeasaurusrex marked this pull request as draft August 7, 2024 11:34
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review August 7, 2024 11:52
Also, remove any tests for `sentry_sdk.configure_scope`.

Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/remove-configure_scope branch from 62560f3 to 73a66ab Compare August 7, 2024 11:53
@szokeasaurusrex
Copy link
Member Author

@antonpirker looks like only Strawberry's Sentry tracing extensions will be incompatible – everything else from Strawberry still works. I removed the imports of those extensions and any functionality based on them; that way, the tests should pass. I will also open an issue in Strawberry's repo to let them know we are dropping support for configure_scope.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@szokeasaurusrex szokeasaurusrex linked an issue Aug 7, 2024 that may be closed by this pull request
@szokeasaurusrex szokeasaurusrex merged commit 275189e into potel-base Aug 7, 2024
123 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/remove-configure_scope branch August 7, 2024 12:42
sentrivana pushed a commit that referenced this pull request Aug 12, 2024
Also, remove any tests for `sentry_sdk.configure_scope`.

Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change needs to go out in a major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove configure_scope
2 participants