Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configure_scope #3402

Closed
szokeasaurusrex opened this issue Aug 7, 2024 · 1 comment · Fixed by #3406
Closed

Remove configure_scope #3402

szokeasaurusrex opened this issue Aug 7, 2024 · 1 comment · Fixed by #3406
Assignees
@szokeasaurusrex
Labels
Breaking change needs to go out in a major

Comments

@szokeasaurusrex
Copy link
Member

Remove sentry_sdk.configure_scope and any backwards compatibility tests testing this function. To be done in potel-base branch.
@szokeasaurusrex szokeasaurusrex added the Breaking change needs to go out in a major label Aug 7, 2024
@szokeasaurusrex szokeasaurusrex self-assigned this Aug 7, 2024
szokeasaurusrex added a commit that referenced this issue Aug 7, 2024
@szokeasaurusrex
feat(api): Remove sentry_sdk.configure_scope
3671a70 
Also, remove any tests for `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
@szokeasaurusrex szokeasaurusrex mentioned this issue Aug 7, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Aug 7, 2024
@szokeasaurusrex
feat(api): Remove sentry_sdk.configure_scope
62560f3 
Also, remove any tests for `sentry_sdk.configure_scope`.

Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
szokeasaurusrex added a commit that referenced this issue Aug 7, 2024
@szokeasaurusrex
feat(api): Remove sentry_sdk.configure_scope
73a66ab 
Also, remove any tests for `sentry_sdk.configure_scope`.

Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
@szokeasaurusrex szokeasaurusrex linked a pull request Aug 7, 2024 that will close this issue
feat(api): Remove sentry_sdk.configure_scope #3406
Merged
szokeasaurusrex added a commit that referenced this issue Aug 7, 2024
@szokeasaurusrex
feat(api): Remove sentry_sdk.configure_scope (#3406)
275189e 
Also, remove any tests for `sentry_sdk.configure_scope`.

Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
@szokeasaurusrex
Copy link
Member Author

Merged in potel-base

sentrivana pushed a commit that referenced this issue Aug 12, 2024
@szokeasaurusrex @sentrivana
feat(api): Remove sentry_sdk.configure_scope (#3406)
fa38dc0 
Also, remove any tests for `sentry_sdk.configure_scope`.

Since Strawberry's deprecated [Sentry tracing extensions](https://strawberry.rocks/docs/extensions/sentry-tracing) import `sentry_sdk.configure_scope`, importing `strawberry.extensions.tracing.SentryTracingExtension` (or `SentryTracingExtensionSync`) will result in an unhandled exception. Therefore, these imports, and any functionality associated with them, have also been removed. This itself is not a breaking change, as it is necessitated by the removal of `sentry_sdk.configure_scope`.

BREAKING CHANGE: Remove `sentry_sdk.configure_scope`.

Closes: #3402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
Breaking change needs to go out in a major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): Remove sentry_sdk.configure_scope getsentry/sentry-python
1 participant
@szokeasaurusrex