Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/code_check and update codecov #187

Merged
merged 2 commits into from
May 17, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner May 12, 2021 22:10
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 12, 2021
@ahcorde
Copy link
Contributor

ahcorde commented May 13, 2021

Require this PR #178

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #187 (65ba3b8) into ign-fuel-tools4 (3e8d0d5) will increase coverage by 2.40%.
The diff coverage is 73.52%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #187      +/-   ##
===================================================
+ Coverage            75.72%   78.13%   +2.40%     
===================================================
  Files                   16       19       +3     
  Lines                 2352     2643     +291     
===================================================
+ Hits                  1781     2065     +284     
- Misses                 571      578       +7     
Impacted Files Coverage Δ
include/ignition/fuel_tools/Model.hh 100.00% <ø> (ø)
include/ignition/fuel_tools/RestClient.hh 100.00% <ø> (ø)
include/ignition/fuel_tools/Result.hh 100.00% <ø> (ø)
src/ClientConfig.cc 84.75% <47.05%> (-3.23%) ⬇️
src/FuelClient.cc 72.36% <61.87%> (+5.69%) ⬆️
src/LocalCache.cc 79.58% <66.66%> (+0.06%) ⬆️
src/Zip.cc 68.75% <70.00%> (+0.39%) ⬆️
src/ign.cc 60.86% <80.45%> (+4.97%) ⬆️
src/CollectionIdentifier.cc 96.15% <96.15%> (ø)
...nclude/ignition/fuel_tools/CollectionIdentifier.hh 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8674ed8...65ba3b8. Read the comment docs.

@chapulina
Copy link
Contributor Author

This is good to go 👍

@ahcorde ahcorde merged commit 3db16a1 into ign-fuel-tools4 May 17, 2021
@ahcorde ahcorde deleted the chapulina/codecheck branch May 17, 2021 07:25
chapulina added a commit that referenced this pull request Aug 13, 2021
* Owner upload (#179)

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Fixed windows download (#178)

* Fixed donwload on Windows

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed interface_TEST

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved windows support

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed test on Windows

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* Fixed test

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix some nits

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved Windows support

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed test on Linux

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed windows tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feddback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Remove tools/code_check and update codecov (#187)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* added fuel update command (#185)

* added fuel update command

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* fixed header

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* fixed build

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* updated docs

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* added header

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* fix

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* nit2

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

* Style, and headers

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fixed world download

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Removed debug

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fix tests

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Fix windows

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>

* 🎈 4.4.0 (#190)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Detect ign instead of using cmake module to check for ignition-tools (#191)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Jose Tomas Lorente <jtlorente@ekumenlabs.com>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants