added fuel update command #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
ahcorde
requested changes
May 11, 2021
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
nkoenig
reviewed
May 18, 2021
There was a problem hiding this comment.
This looks like a good direction. A few high-level comments:
- Add support for the
--headercommand line option, which will allow updating of private resources. - You should use ServerConfig to instead of hardcoding the fuel URL. A pattern you can follow is here: https://github.com/ignitionrobotics/ign-fuel-tools/blob/ign-fuel-tools6/src/ign.cc#L294
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
@nkoenig I don't think I even need to have the URL anywhere. After looking into it, I think the identifier for each model and world has the URL inside, so I can just make the client download it from there, am I right? edit* WorldDownload does not seem to support header, does that mean that it does not use header or that it needs to be fed the header in another way? |
added 4 commits
June 1, 2021 15:32
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Lobotuerk
commented
Jun 2, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>
nkoenig
approved these changes
Jun 4, 2021
chapulina
added a commit
that referenced
this pull request
Aug 13, 2021
* Owner upload (#179) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Fixed windows download (#178) * Fixed donwload on Windows Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed interface_TEST Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved windows support Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test on Windows Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> * Fixed test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fix some nits Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved Windows support Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test on Linux Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed windows tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feddback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Remove tools/code_check and update codecov (#187) Signed-off-by: Louise Poubel <louise@openrobotics.org> * added fuel update command (#185) * added fuel update command Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * fixed header Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * fixed build Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * updated docs Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * added header Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * fix Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * nit2 Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * Style, and headers Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fixed world download Signed-off-by: Nate Koenig <nate@openrobotics.org> * Removed debug Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * 🎈 4.4.0 (#190) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Detect ign instead of using cmake module to check for ignition-tools (#191) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Tomas Lorente <jtlorente@ekumenlabs.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Lorente jtlorente@ekumenlabs.com
🎉 New feature
Update command for fuel
Summary
ign fuel update, supports --onlymodels and --onlyworlds to select if you only want to download one of those. By default downloads both.Test it
Download a model or a world, modify that one in fuel to up the version, call the command and see it update.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge