-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove print()
statements and fix logging usage
#229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 74.61% 74.68% +0.07%
==========================================
Files 157 157
Lines 22867 22907 +40
==========================================
+ Hits 17063 17109 +46
+ Misses 5804 5798 -6 ☔ View full report in Codecov by Sentry. |
@stewartboogert this would be my changes to start with #220 :-) |
the usage of affected functions already raises an exception.
This seems uncontroversial to me, I would merge and release a patch version. |
# noqa: T201
comments for intendedprint()
usageprint()
statements either with logging statements, or remove themthere are some parts that have not been converted. Those are listed in
pyproject.toml
:Those are either "unfinished"(?) parts, or I do not know enough about that code.