-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace print()
statements with logging
module calls
#220
Comments
I already have a large patch for some other print calls, where I
But removing all of them is a huge amount of work, so I stopped at some point. |
Do you have this WIP on some branch? Maybe you could open a draft PR and someone else can work on it at some point. |
not yet, but I will try to get it up in the near future. |
Happy to contribute to this once there is a WIP PR there is a mixture of IO, and there are some areas which logging is used others with a profusion of print. Moving to a more notebook environment, the printout is very annoying. I learned to program in the 80s and still love a print out, apologies. |
after #229, there are some parts that have not been converted from print to logging. Those are listed in pyproject.toml:
this is all code that I personally do not use ever/very often, so I do not have a good understanding of it. After converting the files (switchting to logging calls, or adding noqa comments), the files should be removed from the exclusion list. |
And uncomment this:
pyg4ometry/pyproject.toml
Line 120 in ebbcc37
The text was updated successfully, but these errors were encountered: