Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper for Update Build Status #2141

Merged
merged 4 commits into from
Oct 13, 2018

Conversation

BlythMeister
Copy link
Contributor

@BlythMeister BlythMeister commented Oct 10, 2018

Description

Add ability for updating build status

This extends on:
#2138
#2139
#2140

So has the features of all 3 of the previous pull requests, but adds a little bit more :)

@BlythMeister
Copy link
Contributor Author

@matthid in theory, merging this will merge all the others, but you may want to take them separately to ease the review :)

Update returning of context objects to allow for stepping into process
@BlythMeister BlythMeister force-pushed the FailureContext branch 2 times, most recently from 855852e to ebadc51 Compare October 11, 2018 15:19
@BlythMeister BlythMeister changed the title Helpers for Update Build Status & Failure Messages Helper for Update Build Status Oct 12, 2018
@matthid
Copy link
Member

matthid commented Oct 13, 2018

Conflicts should be fixed after merging BlythMeister#5
Note that I changed the API (and the docs) slightly:

let ctx = Target.runOrDefaultAndGetContext "Deploy"  //Could also use: Target.runAndGetOptionalContext "Deploy"
Target.updateBuildStatus ctx
Target.raiseIfError ctx

instead of

Target.runOrDefaultAndGetContext "Deploy"  //Could also use: Target.runAndGetOptionalContext "Deploy"
|> Target.updateBuildStatus 
|> Target.raiseIfError

@matthid
Copy link
Member

matthid commented Oct 13, 2018

Ok replaced by #2150 (should be merged by github after merging the other one)

@matthid matthid merged commit 26c11e1 into fsprojects:release/next Oct 13, 2018
@BlythMeister
Copy link
Contributor Author

Thanks for all these merges.

There is huge ironey that I don't think I need the features anymore 😂

@matthid
Copy link
Member

matthid commented Oct 13, 2018

Care to elaborate?

@BlythMeister
Copy link
Contributor Author

I realised I could do everything I wanted in my build failure target...

@BlythMeister BlythMeister deleted the FailureContext branch May 11, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants