-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuildState with message #2139
BuildState with message #2139
Conversation
9cb37da
to
b63fc9a
Compare
6560582
to
6408b27
Compare
Did I cause that... |
Oh I see the error, I backed a bit out...and missed this. |
6408b27
to
bd00131
Compare
Can you please merge latest (build should be green again)? |
Hehe, it will have to wait until monday. I've not got access to my laptop until then |
Ok, maybe I'm trying to help by sending a pr to your branch, last time I tried merging directly it looked weird in the pr... |
(I'm also trying to debug why azure pipelines are red on all prs with this) |
I guess worst case, you could create a pr off the head of my branch and enhance like you did with the nunit one? |
@BlythMeister not sure if you meant that but I already opened BlythMeister#2 |
Merged...I hope |
@BlythMeister almost... let me try again with BlythMeister#3 :) |
Try again, now hopefully all is green ;)
Merged again 😂 |
Lol now the diff apparently fixed itself and is now small again oO did you do things differently this time? |
I choose merge...not rebase |
Thanks for helping out, now stuff is green again :) |
Wooooo |
Will send a pr for all your open prs, go through all of them and start the 5.9 release |
looks good, thanks! |
Description
This should not be considered a breaking change since the code itself states that changing
TraceData
is not considered a breaking change.Extends #2138 to prevent later conflicts on the TeamCity code so includes all commits from that PR.