-
-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui) : test portfolio roadmap #54577
Conversation
Yea, the certified user probably doesn't have the English challenges completed. Also, there's no certification for the English curriculum yet. |
Okay I'll go ahead and alter my tests to not include the English curriculum for the certified user. |
This does not have to be a e2e test because it is testing a simple non-interactive functionality. But this should do that job. I left some comments for your review. |
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
@a2937, the tests are failing. Could you take another look. |
Okay now I've got it. |
The test is failing because the signed in user for whatever reason doesn't have those certs and I'm not sure how to fix it so the test user has the right data. Either my local data is bad or the workflow data is bad. |
I will take a look @a2937! |
Hey @a2937, Unfortunately I have to close this because our certified user is not up to date. This means that the icons will never show up because most certifications are not completely finished. Feel free to reopen this when the certified user is back up to date. Sorry of the inconvenience |
Checklist:
main
branch of freeCodeCamp.Closes #XXXXX
Follow up PR to #53963 where the icons are analyzed. For some reason the certified user didn't register as complete for the english curriculum and I'm a little confused.