Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) : test portfolio roadmap #54577

Closed

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Apr 29, 2024

Checklist:

Closes #XXXXX

Follow up PR to #53963 where the icons are analyzed. For some reason the certified user didn't register as complete for the english curriculum and I'm a little confused.

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Apr 29, 2024
bader1379

This comment was marked as off-topic.

bader1379

This comment was marked as off-topic.

@moT01
Copy link
Member

moT01 commented Apr 30, 2024

Yea, the certified user probably doesn't have the English challenges completed. Also, there's no certification for the English curriculum yet.

@a2937
Copy link
Member Author

a2937 commented Apr 30, 2024

Yea, the certified user probably doesn't have the English challenges completed. Also, there's no certification for the English curriculum yet.

Okay I'll go ahead and alter my tests to not include the English curriculum for the certified user.

@a2937 a2937 marked this pull request as ready for review April 30, 2024 18:02
@a2937 a2937 requested a review from a team as a code owner April 30, 2024 18:02
@naomi-lgbt naomi-lgbt enabled auto-merge (squash) May 2, 2024 18:35
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
@ahmaxed
Copy link
Member

ahmaxed commented May 21, 2024

This does not have to be a e2e test because it is testing a simple non-interactive functionality. But this should do that job. I left some comments for your review.

a2937 and others added 2 commits May 21, 2024 16:08
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
@a2937 a2937 requested a review from ahmaxed May 21, 2024 21:04
@ahmaxed
Copy link
Member

ahmaxed commented May 22, 2024

@a2937, the tests are failing. Could you take another look.

@a2937
Copy link
Member Author

a2937 commented May 22, 2024

Okay now I've got it.

@a2937
Copy link
Member Author

a2937 commented May 22, 2024

The test is failing because the signed in user for whatever reason doesn't have those certs and I'm not sure how to fix it so the test user has the right data.

Either my local data is bad or the workflow data is bad.

@Sembauke
Copy link
Member

Sembauke commented Jun 3, 2024

I will take a look @a2937!

@Sembauke
Copy link
Member

Hey @a2937,

Unfortunately I have to close this because our certified user is not up to date. This means that the icons will never show up because most certifications are not completely finished.

Feel free to reopen this when the certified user is back up to date.

Sorry of the inconvenience

@Sembauke Sembauke closed this Jun 13, 2024
auto-merge was automatically disabled June 13, 2024 07:11

Pull request was closed

@a2937 a2937 deleted the feat(UI)/test-portfolio-roadmap branch June 13, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants