Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(learn): create a progress indicator map #53963

Merged

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Mar 3, 2024

Checklist:

Closes #50412

It's a revival of this PR. #52686

@a2937 a2937 requested a review from a team as a code owner March 3, 2024 01:45
@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Mar 3, 2024
@a2937 a2937 changed the title feat: create a progress indicator map feat(learn): create a progress indicator map Mar 4, 2024
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 4, 2024
Copy link
Member

@Sembauke Sembauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @a2937,

We should centre the numbers inside the certifications.

I am not sure if I like the arrows, it might me useful to try a couple of them.

Also, arrows should be white in the dark-theme and black in the light-theme.

image

@Sembauke Sembauke added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Mar 4, 2024
@a2937
Copy link
Member Author

a2937 commented Mar 4, 2024

The arrows aren't exactly a character. They're an SVG as it was the only way I could make something grow and shrink on the page.

@Sembauke
Copy link
Member

Sembauke commented Mar 7, 2024

Let me know if you need any help @a2937!

@a2937
Copy link
Member Author

a2937 commented Mar 8, 2024

Screenshot

Here's the current status.

@a2937 a2937 requested a review from Sembauke March 8, 2024 01:48
@a2937
Copy link
Member Author

a2937 commented Mar 13, 2024

I actually might need a little help making a new arrow shape, if that's alright. Though I'm fairly sure the colors are adjusted for night mode. Additionally, while centering isn't my strong suit; I hope it's closer this time.

@Sembauke
Copy link
Member

Hey @a2937,

Sorry for keeping you waiting so long, I will check it today.

@Sembauke
Copy link
Member

Current progress:
image

@a2937
Copy link
Member Author

a2937 commented Apr 18, 2024

Thank you Sembauke. Those arrows look very lovely.

@Sembauke Sembauke removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 19, 2024
@naomi-lgbt
Copy link
Member

image

Firefox (Ubuntu) does not have the numbers centred.

@a2937
Copy link
Member Author

a2937 commented Apr 22, 2024

Yeah unfortunately I can confirm twice here. It's a possibility that it could be possible that absolute units messing things up. Or perhaps relative units aren't lining things up.

WSL 2:

image

Windows:

image

@naomi-lgbt
Copy link
Member

image

Better now on the ribbons, but not on the greyed out ones.

@a2937
Copy link
Member Author

a2937 commented Apr 23, 2024

image

Okay we finally seem good now.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Out of these three, I've claimed the Machine Learning cert.

There's no visual indication here that I've done so.

@a2937
Copy link
Member Author

a2937 commented Apr 25, 2024

Hmmm...what kind of indication should I give that says the camper has claimed the certification?

@naomi-lgbt
Copy link
Member

I would hide the ribbon part on unclaimed certs, but leave the circle dark.

@naomi-lgbt naomi-lgbt added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 25, 2024
@a2937
Copy link
Member Author

a2937 commented Apr 26, 2024

I can't hit the "I agree to freeCodeCamp's Academic Honesty Policy." button so I can claim my certifications. But I will send in my update.

I'm also not sure if I added the logic right.

@a2937 a2937 requested a review from naomi-lgbt April 26, 2024 16:00
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Awesome work on all of this!

@naomi-lgbt naomi-lgbt merged commit 9f7ecff into freeCodeCamp:main Apr 29, 2024
22 checks passed
@a2937 a2937 deleted the feat(curriculum)/progress-indicator-map branch April 29, 2024 17:36
@ahmaxed
Copy link
Member

ahmaxed commented Apr 29, 2024

@a2937, thank you for the hard work here.
I think isCompleted is not being calculated probably.
Could you please take a look into it, and write test for it in a follow up pr?

@a2937
Copy link
Member Author

a2937 commented Apr 29, 2024

No problem. I'll look into it and start that follow up PR soon.

@a2937 a2937 mentioned this pull request Apr 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add progress indicators to maps
4 participants