Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-10885: removed legacy folder from 2.0 branch #190

Merged
merged 2 commits into from
May 18, 2021
Merged

PLAT-10885: removed legacy folder from 2.0 branch #190

merged 2 commits into from
May 18, 2021

Conversation

symphony-elias
Copy link
Contributor

Ticket

PLAT-10885

Description

Removed legacy folder form 2.0 branch as legacy SDK in master branch

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • [N/A] Unit tests updated or added
  • [N/A] Docstrings added or updated
  • [N/A] Updated the documentation in docs folder

symphony-soufiane
symphony-soufiane approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@symphony-soufiane symphony-soufiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for later to have 2.0 in master and legacy in a separate branch, to be consistent with BDK Java?

@symphony-elias
Copy link
Contributor Author

Does it make sense for later to have 2.0 in master and legacy in a separate branch, to be consistent with BDK Java?

Yes indeed but I'd prefer to wait until the repo is moved to FINOS before making the change.

@symphony-youri
Copy link
Contributor

Does it make sense for later to have 2.0 in master and legacy in a separate branch, to be consistent with BDK Java?

Yes indeed but I'd prefer to wait until the repo is moved to FINOS before making the change.

Yes we will do that once we release the GA version

@symphony-elias symphony-elias merged commit bc726d4 into finos:2.0 May 18, 2021
symphony-elias added a commit that referenced this pull request May 24, 2021
@symphony-elias @symphony-youness
@symphony-mariacristina @symphony-soufiane
PLAT-10698: Deliver 2.0b3 (#193)
68b95cc 
* Updated documentation about slash commands (#181)

* PLAT-10817: documented how to solve self signed certificate issues (#182)

* PLAT-10817: documented how to solve self signed certificate issues

* Updated poetry deps

* PLAT-10564: Documentation of User Joined Room activity (#183)

* Added missing user joined room activity

* Updated links to the developers documentation in markdown doc

* PLAT-10710: Implement the retry mechanism (#180)

* PLAT-10710 Add global and Datafeed retry configuration

* PLAT-10710 Add modified implementation of tenacity.AsyncRetrying handling asynchronously defined retry callbacks

* PLAT-10710 Create a custom retry decorator to fetch the retry configuration from each service instance

* PLAT-10710 Add retry decorator to services

* PLAT-10695 AsyncIO/Proxy usage on Windows (#184)

* PLAT-10695 AsyncIO/Proxy usage on Windows

Default event loop policy has to be changed on Windows + Python 3.8 if a proxy is used. Goal of this PR is to make sure that if these conditions applies our BDK 2.0 examples will still be working as expected, by setting the event loop policy correctly.

* Security review fixes for Python BDK 2.0 (#185)

* PLAT-10870 removed useless self assigment

* PLAT-10867 removed Potential Leak of sensitive information on logs

* PLAT-10862 removed Useless self assigment

* PLAT-10885: removed legacy folder from 2.0 branch (#190)

* PLAT-10829: Added a Message class to make the sending of message easier (#187)

* Updated poetry deps

* PLAT-10829: Added Message class to ease message sending

* PLAT-10866 PLAT-10869 (#191)

* PLAT-10866: Replaced native xml lib by defusedxml

* PLAT-10869: Improved conditional structure in model_utils

* PLAT-10789 Make bot username and appId mandatory in configuration (#189)

* PLAT-10789 Make Bot username and appId mandatory in configuation

Goal of this PR is to make the bot username field mandatory in the configuration file while trying to configure a bot.
Same behaviour is been implemented for the appId when app is found in the config

* PLAT-10698: Bumped version to 2.0b3

Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com>
Co-authored-by: Mariacristina De Dominicis <65179248+symphony-mariacristina@users.noreply.github.com>
Co-authored-by: Soufiane Aourinmouche <52406574+symphony-soufiane@users.noreply.github.com>
symphony-youness added a commit to symphony-youness/symphony-api-client-python that referenced this pull request Jun 4, 2021
@symphony-elias @symphony-youness
@symphony-mariacristina @symphony-soufiane
PLAT-10698: Deliver 2.0b3 (finos#193)
ca9542c 
* Updated documentation about slash commands (finos#181)

* PLAT-10817: documented how to solve self signed certificate issues (finos#182)

* PLAT-10817: documented how to solve self signed certificate issues

* Updated poetry deps

* PLAT-10564: Documentation of User Joined Room activity (finos#183)

* Added missing user joined room activity

* Updated links to the developers documentation in markdown doc

* PLAT-10710: Implement the retry mechanism (finos#180)

* PLAT-10710 Add global and Datafeed retry configuration

* PLAT-10710 Add modified implementation of tenacity.AsyncRetrying handling asynchronously defined retry callbacks

* PLAT-10710 Create a custom retry decorator to fetch the retry configuration from each service instance

* PLAT-10710 Add retry decorator to services

* PLAT-10695 AsyncIO/Proxy usage on Windows (finos#184)

* PLAT-10695 AsyncIO/Proxy usage on Windows

Default event loop policy has to be changed on Windows + Python 3.8 if a proxy is used. Goal of this PR is to make sure that if these conditions applies our BDK 2.0 examples will still be working as expected, by setting the event loop policy correctly.

* Security review fixes for Python BDK 2.0 (finos#185)

* PLAT-10870 removed useless self assigment

* PLAT-10867 removed Potential Leak of sensitive information on logs

* PLAT-10862 removed Useless self assigment

* PLAT-10885: removed legacy folder from 2.0 branch (finos#190)

* PLAT-10829: Added a Message class to make the sending of message easier (finos#187)

* Updated poetry deps

* PLAT-10829: Added Message class to ease message sending

* PLAT-10866 PLAT-10869 (finos#191)

* PLAT-10866: Replaced native xml lib by defusedxml

* PLAT-10869: Improved conditional structure in model_utils

* PLAT-10789 Make bot username and appId mandatory in configuration (finos#189)

* PLAT-10789 Make Bot username and appId mandatory in configuation

Goal of this PR is to make the bot username field mandatory in the configuration file while trying to configure a bot.
Same behaviour is been implemented for the appId when app is found in the config

* PLAT-10698: Bumped version to 2.0b3

Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com>
Co-authored-by: Mariacristina De Dominicis <65179248+symphony-mariacristina@users.noreply.github.com>
Co-authored-by: Soufiane Aourinmouche <52406574+symphony-soufiane@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphony-soufiane symphony-soufiane symphony-soufiane approved these changes

@symphony-youri symphony-youri symphony-youri approved these changes

@symphony-youness symphony-youness Awaiting requested review from symphony-youness

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@symphony-elias @symphony-youri @symphony-soufiane