PLAT-10564: Documentation of User Joined Room activity #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-elias
requested review from
thibauult,
symphony-youri,
symphony-youness and
a team
symphony-youri
approved these changes
May 4, 2021
symphony-elias
added a commit
that referenced
this pull request
May 24, 2021
* Updated documentation about slash commands (#181) * PLAT-10817: documented how to solve self signed certificate issues (#182) * PLAT-10817: documented how to solve self signed certificate issues * Updated poetry deps * PLAT-10564: Documentation of User Joined Room activity (#183) * Added missing user joined room activity * Updated links to the developers documentation in markdown doc * PLAT-10710: Implement the retry mechanism (#180) * PLAT-10710 Add global and Datafeed retry configuration * PLAT-10710 Add modified implementation of tenacity.AsyncRetrying handling asynchronously defined retry callbacks * PLAT-10710 Create a custom retry decorator to fetch the retry configuration from each service instance * PLAT-10710 Add retry decorator to services * PLAT-10695 AsyncIO/Proxy usage on Windows (#184) * PLAT-10695 AsyncIO/Proxy usage on Windows Default event loop policy has to be changed on Windows + Python 3.8 if a proxy is used. Goal of this PR is to make sure that if these conditions applies our BDK 2.0 examples will still be working as expected, by setting the event loop policy correctly. * Security review fixes for Python BDK 2.0 (#185) * PLAT-10870 removed useless self assigment * PLAT-10867 removed Potential Leak of sensitive information on logs * PLAT-10862 removed Useless self assigment * PLAT-10885: removed legacy folder from 2.0 branch (#190) * PLAT-10829: Added a Message class to make the sending of message easier (#187) * Updated poetry deps * PLAT-10829: Added Message class to ease message sending * PLAT-10866 PLAT-10869 (#191) * PLAT-10866: Replaced native xml lib by defusedxml * PLAT-10869: Improved conditional structure in model_utils * PLAT-10789 Make bot username and appId mandatory in configuration (#189) * PLAT-10789 Make Bot username and appId mandatory in configuation Goal of this PR is to make the bot username field mandatory in the configuration file while trying to configure a bot. Same behaviour is been implemented for the appId when app is found in the config * PLAT-10698: Bumped version to 2.0b3 Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com> Co-authored-by: Mariacristina De Dominicis <65179248+symphony-mariacristina@users.noreply.github.com> Co-authored-by: Soufiane Aourinmouche <52406574+symphony-soufiane@users.noreply.github.com>
symphony-youness
added a commit
to symphony-youness/symphony-api-client-python
that referenced
this pull request
Jun 4, 2021
* Updated documentation about slash commands (finos#181) * PLAT-10817: documented how to solve self signed certificate issues (finos#182) * PLAT-10817: documented how to solve self signed certificate issues * Updated poetry deps * PLAT-10564: Documentation of User Joined Room activity (finos#183) * Added missing user joined room activity * Updated links to the developers documentation in markdown doc * PLAT-10710: Implement the retry mechanism (finos#180) * PLAT-10710 Add global and Datafeed retry configuration * PLAT-10710 Add modified implementation of tenacity.AsyncRetrying handling asynchronously defined retry callbacks * PLAT-10710 Create a custom retry decorator to fetch the retry configuration from each service instance * PLAT-10710 Add retry decorator to services * PLAT-10695 AsyncIO/Proxy usage on Windows (finos#184) * PLAT-10695 AsyncIO/Proxy usage on Windows Default event loop policy has to be changed on Windows + Python 3.8 if a proxy is used. Goal of this PR is to make sure that if these conditions applies our BDK 2.0 examples will still be working as expected, by setting the event loop policy correctly. * Security review fixes for Python BDK 2.0 (finos#185) * PLAT-10870 removed useless self assigment * PLAT-10867 removed Potential Leak of sensitive information on logs * PLAT-10862 removed Useless self assigment * PLAT-10885: removed legacy folder from 2.0 branch (finos#190) * PLAT-10829: Added a Message class to make the sending of message easier (finos#187) * Updated poetry deps * PLAT-10829: Added Message class to ease message sending * PLAT-10866 PLAT-10869 (finos#191) * PLAT-10866: Replaced native xml lib by defusedxml * PLAT-10869: Improved conditional structure in model_utils * PLAT-10789 Make bot username and appId mandatory in configuration (finos#189) * PLAT-10789 Make Bot username and appId mandatory in configuation Goal of this PR is to make the bot username field mandatory in the configuration file while trying to configure a bot. Same behaviour is been implemented for the appId when app is found in the config * PLAT-10698: Bumped version to 2.0b3 Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com> Co-authored-by: Mariacristina De Dominicis <65179248+symphony-mariacristina@users.noreply.github.com> Co-authored-by: Soufiane Aourinmouche <52406574+symphony-soufiane@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-10564
Description
I realized we were missing documentation on the user joined room activity.
Updates to the symphony developers documentation were also made.
Checklist