Added suppress_message() to OBOMessageService #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +98,7 @@ def __init__(self, messages_api: MultiAttachmentsMessagesApi, | |||
| attachment_api: AttachmentsApi, | |||
| default_api: DefaultApi, | |||
| auth_session: AuthSession): | |||
| super().__init__(messages_api, auth_session) | |||
| super().__init__(messages_api, auth_session, message_suppression_api) | |||
| self._message_api = message_api | |||
| self._message_suppression_api = message_suppression_api | |||
There was a problem hiding this comment.
Please remove this line as it is only used in super class
There was a problem hiding this comment.
Sorry Elias, can you specify what you want removed? I thought the message_suppression_api needs to be a part of the parent class constructor since the suppress_message endpoint is OBO enabled. Can you clarify? Thanks
symphony-elias
added a commit
that referenced
this pull request
Apr 22, 2021
* PLAT-10652: regenerated all models to enable autocomplete (#162) * PLAT-10652: regenerated all model and api files to enable autocomplete * Created a script for api generation and documented it * Updated ApiClient to ignore unknown fields when deserializing json * PLAT-10555: Deserializing models in tests (#168) Update the tests to use the generated models instead of creating objects from a JSON file. * PLAT-10652: replaced wget with curl when downloading swagger specs in generate_client_api.sh (#169) * PLAT-10278: OBO certificate authentication (#173) * PLAT-10278: Implemented OBO cert authentication * Updated authentication documentation for OBO cert authentication * PLAT-10758: Remove the @pytest.mark.skip and tests fixes (#171) - modified the generation script to use the pod-api-public - Update generated models - Remove skip test annotations - Remove unused test return payloads - Fixed presence service / tests * PLAT-10564: Implemented UserJoinedRoom Acitivity (#167) * Implemented UserJoinedRoom Acitivity * updated path to config.yaml * user_joined_room.py added and registry updated * added user joined room activity tests Co-authored-by: Reed Feldman <rfeldman@bates.edu> * PLAT-10536: Extension App certificate authentication (#174) * PLAT-10536: Ext App Cert authentication * Updated documentation * Removed sphinx warnings + references in activity api doc * Updated poetry deps * PLAT-10706: Implemented @slash for slash commands (#175) * Added suppress_message() to OBOMessageService (#172) * Added suppress_message() to OBOMessageService * moved example of message_suppress() to examples/messages.py * removed message_suppression_api attribute from child class MessageService Co-authored-by: Reed Feldman <rfeldman@bates.edu> * PLAT-10645: Aligned and rearranged examples (#176) * Rearranged examples and made them use logging.conf * Kept most relevant methods in examples * Updated markdown documentation * Added requirements on minimum python version in docs * PLAT-10276: Bot certificate authentication (#177) * Fixed logging.config imports in examples (#178) * Bumped version to 2.0b2 Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com> Co-authored-by: Reed Feldman <reed.feldman@gmail.com> Co-authored-by: Reed Feldman <rfeldman@bates.edu>
symphony-youness
added a commit
to symphony-youness/symphony-api-client-python
that referenced
this pull request
Jun 4, 2021
* PLAT-10652: regenerated all models to enable autocomplete (finos#162) * PLAT-10652: regenerated all model and api files to enable autocomplete * Created a script for api generation and documented it * Updated ApiClient to ignore unknown fields when deserializing json * PLAT-10555: Deserializing models in tests (finos#168) Update the tests to use the generated models instead of creating objects from a JSON file. * PLAT-10652: replaced wget with curl when downloading swagger specs in generate_client_api.sh (finos#169) * PLAT-10278: OBO certificate authentication (finos#173) * PLAT-10278: Implemented OBO cert authentication * Updated authentication documentation for OBO cert authentication * PLAT-10758: Remove the @pytest.mark.skip and tests fixes (finos#171) - modified the generation script to use the pod-api-public - Update generated models - Remove skip test annotations - Remove unused test return payloads - Fixed presence service / tests * PLAT-10564: Implemented UserJoinedRoom Acitivity (finos#167) * Implemented UserJoinedRoom Acitivity * updated path to config.yaml * user_joined_room.py added and registry updated * added user joined room activity tests Co-authored-by: Reed Feldman <rfeldman@bates.edu> * PLAT-10536: Extension App certificate authentication (finos#174) * PLAT-10536: Ext App Cert authentication * Updated documentation * Removed sphinx warnings + references in activity api doc * Updated poetry deps * PLAT-10706: Implemented @slash for slash commands (finos#175) * Added suppress_message() to OBOMessageService (finos#172) * Added suppress_message() to OBOMessageService * moved example of message_suppress() to examples/messages.py * removed message_suppression_api attribute from child class MessageService Co-authored-by: Reed Feldman <rfeldman@bates.edu> * PLAT-10645: Aligned and rearranged examples (finos#176) * Rearranged examples and made them use logging.conf * Kept most relevant methods in examples * Updated markdown documentation * Added requirements on minimum python version in docs * PLAT-10276: Bot certificate authentication (finos#177) * Fixed logging.config imports in examples (finos#178) * Bumped version to 2.0b2 Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com> Co-authored-by: Reed Feldman <reed.feldman@gmail.com> Co-authored-by: Reed Feldman <rfeldman@bates.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PLAT-10696
Description
Added suppress_message() method to OBOMessageService
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist