Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-10758: Remove the @pytest.mark.skip and tests fixes #171

Merged
merged 5 commits into from
Apr 14, 2021
Merged

PLAT-10758: Remove the @pytest.mark.skip and tests fixes #171

merged 5 commits into from
Apr 14, 2021

Conversation

symphony-youness
Copy link
Contributor

Ticket

PLAT-10758

Description

Updated the generated models to take make the a pod_model>Product> sku property, optional
Removed the skip annotation from tests

Minor fixes in the PresenceService and related tests
Fixed forgotten object deserialization in the PresenceService tests
Removed the functions that deserializes JSON to python object in the resource utils

Dependencies

List the other pull requests that should be merged before/along this one.

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • Docstrings added or updated
  • Updated the documentation in docs folder

@symphony-youness
PLAT-9996 correct generation script
fe04569
@symphony-youness
PLAT-10555 Update generated models
c7b7ae5 
Because we have a new spec version, all files are modified.
We observe 2 main changes:
- sku property is not required in pod_model>product
- removal of the agent_api>SystemApi>__v2_health_check_get
@symphony-youness
PLAT-10555 Remove skip test annotations
12fa9ea
@symphony-youness
PLAT-10555 Remove unused test return payloads
2428042 
- remove unused payloads
- Fix return of SignalService > delete_signal method
@symphony-youness
PLAT-10555 Fixed presence service / tests
47b37a9 
- Fixed presence service returns
- Removed object_from_json and object_from_json_relative_path from ressource utils
- Fixed related tests
@symphony-youness symphony-youness requested review from symphony-elias and a team April 13, 2021 11:11
symphony-elias
symphony-elias reviewed Apr 13, 2021
View reviewed changes
templates/generate_client_api.sh
@@ -37,4 +37,4 @@ generate_files() {
generate_files https://raw.githubusercontent.com/symphonyoss/symphony-api-spec/master/agent/agent-api-public.yaml agent
generate_files https://raw.githubusercontent.com/symphonyoss/symphony-api-spec/master/authenticator/authenticator-api-public.yaml auth
generate_files https://raw.githubusercontent.com/symphonyoss/symphony-api-spec/master/login/login-api-public.yaml login
generate_files https://raw.githubusercontent.com/symphonyoss/symphony-api-spec/master/pod/pod-api-public-deprecated.yaml pod
generate_files https://raw.githubusercontent.com/symphonyoss/symphony-api-spec/master/pod/pod-api-public.yaml pod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@symphony-youness Why did you changed it ? If I remember well, some endpoints were missing in the non deprecated pod api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was a mistake 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to recompile the java bdk with 20.12 specs and pod-api-public.yaml and it seems fine. So it is fine to use the pod-api-public.yaml

@symphony-youri symphony-youri changed the title PLAT-9996: Remove the @pytest.mark.skip and tests fixes PLAT-10758: Remove the @pytest.mark.skip and tests fixes Apr 13, 2021
symphony-youri
symphony-youri reviewed Apr 13, 2021
View reviewed changes
tests/core/service/presence/presence_service_test.py

presence = await presence_service.get_presence()

assert presence.category == "AVAILABLE"
assert presence.userId == 14568529068038
assert presence.user_id == 14568529068038
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it related to the change here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see catch the usage of this in the previous ticket.
The last commit removes all remaining usage of objects directly created from Json.

symphony-elias
symphony-elias approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@symphony-elias symphony-elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@symphony-youness symphony-youness merged commit 25b9b3d into finos:2.0 Apr 14, 2021
@symphony-youness symphony-youness deleted the PLAT-9996 branch April 15, 2021 14:48
symphony-elias added a commit that referenced this pull request Apr 22, 2021
@symphony-elias @symphony-youness @reedvfeldman
PLAT-10794: Release Python BDK 2.0b2 (#179)
737853f 
* PLAT-10652: regenerated all models to enable autocomplete (#162)

* PLAT-10652: regenerated all model and api files to enable autocomplete

* Created a script for api generation and documented it

* Updated ApiClient to ignore unknown fields when deserializing json

* PLAT-10555: Deserializing models in tests (#168)

Update the tests to use the generated models instead of creating objects from a JSON file.

* PLAT-10652: replaced wget with curl when downloading swagger specs in generate_client_api.sh (#169)

* PLAT-10278: OBO certificate authentication (#173)

* PLAT-10278: Implemented OBO cert authentication

* Updated authentication documentation for OBO cert authentication

* PLAT-10758: Remove the @pytest.mark.skip and tests fixes (#171)

- modified the generation script to use the pod-api-public
- Update generated models
- Remove skip test annotations
- Remove unused test return payloads
- Fixed presence service / tests

* PLAT-10564: Implemented UserJoinedRoom Acitivity (#167)

* Implemented UserJoinedRoom Acitivity

* updated path to config.yaml

* user_joined_room.py added and registry updated

* added user joined room activity tests

Co-authored-by: Reed Feldman <rfeldman@bates.edu>

* PLAT-10536: Extension App certificate authentication (#174)

* PLAT-10536: Ext App Cert authentication

* Updated documentation

* Removed sphinx warnings + references in activity api doc

* Updated poetry deps

* PLAT-10706: Implemented @slash for slash commands (#175)

* Added suppress_message() to OBOMessageService (#172)

* Added suppress_message() to OBOMessageService

* moved example of message_suppress() to examples/messages.py

* removed message_suppression_api attribute from child class MessageService

Co-authored-by: Reed Feldman <rfeldman@bates.edu>

* PLAT-10645: Aligned and rearranged examples (#176)

* Rearranged examples and made them use logging.conf

* Kept most relevant methods in examples

* Updated markdown documentation

* Added requirements on minimum python version in docs

* PLAT-10276: Bot certificate authentication (#177)

* Fixed logging.config imports in examples (#178)

* Bumped version to 2.0b2

Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com>
Co-authored-by: Reed Feldman <reed.feldman@gmail.com>
Co-authored-by: Reed Feldman <rfeldman@bates.edu>
symphony-youness added a commit to symphony-youness/symphony-api-client-python that referenced this pull request Jun 4, 2021
@symphony-elias @symphony-youness @reedvfeldman
PLAT-10794: Release Python BDK 2.0b2 (finos#179)
ad9250b 
* PLAT-10652: regenerated all models to enable autocomplete (finos#162)

* PLAT-10652: regenerated all model and api files to enable autocomplete

* Created a script for api generation and documented it

* Updated ApiClient to ignore unknown fields when deserializing json

* PLAT-10555: Deserializing models in tests (finos#168)

Update the tests to use the generated models instead of creating objects from a JSON file.

* PLAT-10652: replaced wget with curl when downloading swagger specs in generate_client_api.sh (finos#169)

* PLAT-10278: OBO certificate authentication (finos#173)

* PLAT-10278: Implemented OBO cert authentication

* Updated authentication documentation for OBO cert authentication

* PLAT-10758: Remove the @pytest.mark.skip and tests fixes (finos#171)

- modified the generation script to use the pod-api-public
- Update generated models
- Remove skip test annotations
- Remove unused test return payloads
- Fixed presence service / tests

* PLAT-10564: Implemented UserJoinedRoom Acitivity (finos#167)

* Implemented UserJoinedRoom Acitivity

* updated path to config.yaml

* user_joined_room.py added and registry updated

* added user joined room activity tests

Co-authored-by: Reed Feldman <rfeldman@bates.edu>

* PLAT-10536: Extension App certificate authentication (finos#174)

* PLAT-10536: Ext App Cert authentication

* Updated documentation

* Removed sphinx warnings + references in activity api doc

* Updated poetry deps

* PLAT-10706: Implemented @slash for slash commands (finos#175)

* Added suppress_message() to OBOMessageService (finos#172)

* Added suppress_message() to OBOMessageService

* moved example of message_suppress() to examples/messages.py

* removed message_suppression_api attribute from child class MessageService

Co-authored-by: Reed Feldman <rfeldman@bates.edu>

* PLAT-10645: Aligned and rearranged examples (finos#176)

* Rearranged examples and made them use logging.conf

* Kept most relevant methods in examples

* Updated markdown documentation

* Added requirements on minimum python version in docs

* PLAT-10276: Bot certificate authentication (finos#177)

* Fixed logging.config imports in examples (finos#178)

* Bumped version to 2.0b2

Co-authored-by: symphony-youness <76746033+symphony-youness@users.noreply.github.com>
Co-authored-by: Reed Feldman <reed.feldman@gmail.com>
Co-authored-by: Reed Feldman <rfeldman@bates.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphony-youri symphony-youri symphony-youri left review comments

@symphony-elias symphony-elias symphony-elias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@symphony-youness @symphony-youri @symphony-elias