Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jenkins converters #95

Merged
merged 19 commits into from
Oct 1, 2021
Merged

Add Jenkins converters #95

merged 19 commits into from
Oct 1, 2021

Conversation

Roma-Kyrnis
Copy link
Contributor

@Roma-Kyrnis Roma-Kyrnis commented Sep 24, 2021

Description

#94

Type of change

  • Bug fix
  • New feature
  • Breaking change

@tovbinm tovbinm changed the title add Jenkins converter Add Jenkins converters Sep 24, 2021
@tovbinm
Copy link
Contributor

tovbinm commented Sep 27, 2021

Please add tests.

Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, otherwise, lgtm!

@tovbinm
Copy link
Contributor

tovbinm commented Oct 1, 2021

@Roma-Kyrnis can you please address the comments so we can merge this?

@tovbinm tovbinm merged commit 0bfbcbe into main Oct 1, 2021
@tovbinm tovbinm deleted the rk/add-jenkins-converter branch October 1, 2021 17:41
Roma-Kyrnis added a commit that referenced this pull request Oct 8, 2021
cjwooo pushed a commit that referenced this pull request Oct 8, 2021
* asana begin

* identity file error

* add asana destination

* FAI-441 - Implement Phabricator check connection + streams (#105)

* Cache repostories in Phabricator streams (#106)

* Add Jenkins converters (#95)

* FAI-441 - Added revisions & users streams to Phabricator source + bump version (#113)

* FA-441 - Added projects stream to Phabricator + cleanup (#114)

* add tests; fix story creator; update task stream

* remove github comment

* don't create user on tasks and stories

* fix wroting records quantity

* add tags; save TMS TaskBords on Task

* use null to undefined values; rename interfaces

* Fix Jenkins converter's url (#115)

* update jenkins url; remove lodash

* not update job's url

Co-authored-by: Matthew Tovbin <tovbinm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants