-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jenkins converters #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
reviewed
Sep 24, 2021
destinations/faros-destination/src/converters/jenkins/builds.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Sep 24, 2021
destinations/faros-destination/src/converters/jenkins/common.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Sep 25, 2021
Please add tests. |
…/add-jenkins-converter
…e-connectors into rk/add-jenkins-converter
…e-connectors into rk/add-jenkins-converter
cjwooo
approved these changes
Sep 28, 2021
destinations/faros-destination/src/converters/jenkins/common.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Sep 30, 2021
destinations/faros-destination/src/converters/jenkins/common.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Sep 30, 2021
tovbinm
reviewed
Sep 30, 2021
tovbinm
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, otherwise, lgtm!
@Roma-Kyrnis can you please address the comments so we can merge this? |
…e-connectors into rk/add-jenkins-converter
Roma-Kyrnis
added a commit
that referenced
this pull request
Oct 8, 2021
cjwooo
pushed a commit
that referenced
this pull request
Oct 8, 2021
* asana begin * identity file error * add asana destination * FAI-441 - Implement Phabricator check connection + streams (#105) * Cache repostories in Phabricator streams (#106) * Add Jenkins converters (#95) * FAI-441 - Added revisions & users streams to Phabricator source + bump version (#113) * FA-441 - Added projects stream to Phabricator + cleanup (#114) * add tests; fix story creator; update task stream * remove github comment * don't create user on tasks and stories * fix wroting records quantity * add tags; save TMS TaskBords on Task * use null to undefined values; rename interfaces * Fix Jenkins converter's url (#115) * update jenkins url; remove lodash * not update job's url Co-authored-by: Matthew Tovbin <tovbinm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#94
Type of change