Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jenkins converter's url #115

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Fix Jenkins converter's url #115

merged 2 commits into from
Oct 6, 2021

Conversation

Roma-Kyrnis
Copy link
Contributor

@Roma-Kyrnis Roma-Kyrnis commented Oct 3, 2021

Description

Fix saving incorrect url to CICD's organizations and jobs. Before these changes Job's url look like: http:// and now: http://localhost:8080/job/Faros-test-job/. Use javascript function toLowerCase instread of lodash.

Type of change

  • Bug fix
  • New feature
  • Breaking change

@Roma-Kyrnis Roma-Kyrnis changed the title Fix Jenkins url Fix Jenkins converter's url Oct 3, 2021
Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a clean description what is this change about?

@Roma-Kyrnis
Copy link
Contributor Author

Description updated

@tovbinm tovbinm requested a review from cjwooo October 4, 2021 06:27
@cjwooo cjwooo merged commit 531275c into main Oct 6, 2021
@cjwooo cjwooo deleted the rk/fix-jenkins-converters-url branch October 6, 2021 22:03
Roma-Kyrnis added a commit that referenced this pull request Oct 8, 2021
* update jenkins url; remove lodash

* not update job's url
cjwooo pushed a commit that referenced this pull request Oct 8, 2021
* asana begin

* identity file error

* add asana destination

* FAI-441 - Implement Phabricator check connection + streams (#105)

* Cache repostories in Phabricator streams (#106)

* Add Jenkins converters (#95)

* FAI-441 - Added revisions & users streams to Phabricator source + bump version (#113)

* FA-441 - Added projects stream to Phabricator + cleanup (#114)

* add tests; fix story creator; update task stream

* remove github comment

* don't create user on tasks and stories

* fix wroting records quantity

* add tags; save TMS TaskBords on Task

* use null to undefined values; rename interfaces

* Fix Jenkins converter's url (#115)

* update jenkins url; remove lodash

* not update job's url

Co-authored-by: Matthew Tovbin <tovbinm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants